From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933089AbdCLJix (ORCPT ); Sun, 12 Mar 2017 05:38:53 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:17134 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754202AbdCLJit (ORCPT ); Sun, 12 Mar 2017 05:38:49 -0400 From: Vegard Nossum To: Richard Weinberger Cc: user-mode-linux-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Vegard Nossum Subject: [PATCH] um: use KERN_CONT in stack dump Date: Sun, 12 Mar 2017 10:38:20 +0100 Message-Id: <20170312093820.12044-1-vegard.nossum@oracle.com> X-Mailer: git-send-email 2.12.0.rc0 X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Without KERN_CONT, the symbol will appear on a new line, making stack traces completely unreadable: Call Trace: [<6008e891>] ? printk+0x0/0x94 [<6001cce6>] show_stack+0xfe/0x15b [<600666ec>] ? dump_stack_print_info+0xe1/0xea [<6008e891>] ? printk+0x0/0x94 [<6023e826>] ? bust_spinlocks+0x0/0x4f [<602343b8>] dump_stack+0x2a/0x2c [<6008e662>] panic+0x170/0x31e [<6008e4f2>] ? panic+0x0/0x31e This makes it readable again: Call Trace: [<6008e891>] ? printk+0x0/0x94 [<6001cce6>] show_stack+0xfe/0x15b [<600666ec>] ? dump_stack_print_info+0xe1/0xea [<6008e891>] ? printk+0x0/0x94 [<6023e826>] ? bust_spinlocks+0x0/0x4f [<602343b8>] dump_stack+0x2a/0x2c [<6008e662>] panic+0x170/0x31e Signed-off-by: Vegard Nossum --- arch/um/kernel/sysrq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/um/kernel/sysrq.c b/arch/um/kernel/sysrq.c index a76295f7ede9..edf1f80123e7 100644 --- a/arch/um/kernel/sysrq.c +++ b/arch/um/kernel/sysrq.c @@ -22,7 +22,7 @@ static void _print_addr(void *data, unsigned long address, int reliable) { pr_info(" [<%08lx>]", address); pr_cont(" %s", reliable ? "" : "? "); - print_symbol("%s", address); + print_symbol(KERN_CONT "%s", address); pr_cont("\n"); } -- 2.12.0.rc0