From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934225AbdCLNfk (ORCPT ); Sun, 12 Mar 2017 09:35:40 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:45428 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934167AbdCLNf3 (ORCPT ); Sun, 12 Mar 2017 09:35:29 -0400 Date: Sun, 12 Mar 2017 14:34:57 +0100 From: Greg KH To: simran singhal Cc: devel@driverdev.osuosl.org, outreachy-kernel@googlegroups.com, arve@android.com, riandrews@android.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] staging: android: Replace strcpy with strlcpy Message-ID: <20170312133457.GA27791@kroah.com> References: <20170311220244.GA21700@singhal-Inspiron-5558> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170311220244.GA21700@singhal-Inspiron-5558> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 12, 2017 at 03:32:44AM +0530, simran singhal wrote: > Replace strcpy with strlcpy as strcpy does not check for buffer > overflow. Can there be a buffer overflow here? If not, then strcpy is just fine to use. Do you see a potential code path here that actually is a problem using this? > This is found using Flawfinder. You mean 'grep'? :) If not, what exactly does "Flawfinder" point out is wrong with the code here? At first glance, I can't find it, but perhaps the tool, and your audit, provided more information? thanks, greg k-h