From: Rob Herring <robh@kernel.org>
To: Ryan Lee <ryans.lee@maximintegrated.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org, mark.rutland@arm.com,
perex@perex.cz, tiwai@suse.com, arnd@arndb.de,
michael@amarulasolutions.com, oder_chiou@realtek.com,
yesanishhere@gmail.com, jacob@teenage.engineering,
Damien.Horsley@imgtec.com, bardliao@realtek.com,
kuninori.morimoto.gx@renesas.com, petr@barix.com,
lars@metafoo.de, nh6z@nh6z.net, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 01/10] ALSA SoC MAX98927 driver - Initial release
Date: Sun, 12 Mar 2017 09:11:02 -0500 [thread overview]
Message-ID: <20170312141102.fxigzia2nvfuli2d@rob-hp-laptop> (raw)
In-Reply-To: <1488552768-14901-2-git-send-email-ryans.lee@maximintegrated.com>
On Fri, Mar 03, 2017 at 11:52:39PM +0900, Ryan Lee wrote:
> From: Ryan Lee <RyanS.Lee@maximintegrated.com>
>
> Signed-off-by: Ryan Lee <ryans.lee@maximintegrated.com>
> ---
>
> Initial release of ALSA SoC MAX98927 driver.
>
> .../devicetree/bindings/sound/max98927.txt | 32 +
In addition to what Mark said, please split bindings to a separate
patch.
> sound/soc/codecs/Kconfig | 5 +
> sound/soc/codecs/Makefile | 2 +
> sound/soc/codecs/max98927.c | 954 +++++++++++++++
> sound/soc/codecs/max98927.h | 1253 ++++++++++++++++++++
> 5 files changed, 2246 insertions(+)
> create mode 100755 Documentation/devicetree/bindings/sound/max98927.txt
> mode change 100644 => 100755 sound/soc/codecs/Kconfig
> mode change 100644 => 100755 sound/soc/codecs/Makefile
> create mode 100755 sound/soc/codecs/max98927.c
> create mode 100755 sound/soc/codecs/max98927.h
These files should not be executable.
Rob
next prev parent reply other threads:[~2017-03-12 14:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 14:52 [PATCH 00/10] ALSA SoC MAX98927 driver - revision Ryan Lee
2017-03-03 14:52 ` [PATCH 01/10] ALSA SoC MAX98927 driver - Initial release Ryan Lee
2017-03-06 10:35 ` Mark Brown
2017-03-12 14:11 ` Rob Herring [this message]
2017-03-03 14:52 ` [PATCH 02/10] Updated max98927_reg table with physical defaults. Replaced max98927.h for better legibility Ryan Lee
2017-03-06 10:30 ` Mark Brown
2017-03-03 14:52 ` [PATCH 03/10] Removed the secondary device initialization from the primary device initialization. Removed manual register configuration from devicetree Ryan Lee
2017-03-03 14:52 ` [PATCH 04/10] Modified indentation Ryan Lee
2017-03-03 14:52 ` [PATCH 05/10] Replaced pr_err by dev_err. Modified debug message Ryan Lee
2017-03-03 14:52 ` [PATCH 06/10] Added mask variable to apply it in one round after the switch Ryan Lee
2017-03-03 14:52 ` [PATCH 07/10] Modified initialization code of VI sensing Ryan Lee
2017-03-03 14:52 ` [PATCH 08/10] Added DAI Sel Mux and minor updates Ryan Lee
2017-03-03 14:52 ` [PATCH 09/10] Added ACPI support. Changed snd_kcontrol_chip to snd_soc_kcontrol_codec Ryan Lee
2017-03-03 14:52 ` [PATCH 10/10] Added vendor prefix. Added range information Ryan Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170312141102.fxigzia2nvfuli2d@rob-hp-laptop \
--to=robh@kernel.org \
--cc=Damien.Horsley@imgtec.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=bardliao@realtek.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jacob@teenage.engineering \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michael@amarulasolutions.com \
--cc=nh6z@nh6z.net \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=petr@barix.com \
--cc=ryans.lee@maximintegrated.com \
--cc=tiwai@suse.com \
--cc=yesanishhere@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®