mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Radoslaw Pietrzyk <radoslaw.pietrzyk@gmail.com>
Cc: thomas.petazzoni@free-electrons.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: fbtft: Allows bpp to be set from dt
Date: Sun, 12 Mar 2017 15:27:34 +0100	[thread overview]
Message-ID: <20170312142734.GA19066@kroah.com> (raw)
In-Reply-To: <1489137927-13347-2-git-send-email-radoslaw.pietrzyk@gmail.com>

On Fri, Mar 10, 2017 at 10:25:27AM +0100, Radoslaw Pietrzyk wrote:
> Allows bpp to be set from dt
> 
> Signed-off-by: Radoslaw Pietrzyk <radoslaw.pietrzyk@gmail.com>
> ---
>  drivers/staging/fbtft/fbtft-core.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
> index 7c8af29..b25288b 100644
> --- a/drivers/staging/fbtft/fbtft-core.c
> +++ b/drivers/staging/fbtft/fbtft-core.c
> @@ -685,6 +685,8 @@ struct fb_info *fbtft_framebuffer_alloc(struct fbtft_display *display,
>  	/* override driver values? */
>  	if (pdata->fps)
>  		fps = pdata->fps;
> +	if (pdata->bpp)
> +		bpp = pdata->bpp;
>  	if (pdata->txbuflen)
>  		txbuflen = pdata->txbuflen;
>  	if (pdata->display.init_sequence)

This breaks the build, how did you test this???

thanks,

greg k-h

  reply	other threads:[~2017-03-12 14:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-10  9:25 [PATCH] Allows setting bpp " Radoslaw Pietrzyk
2017-03-10  9:25 ` [PATCH] staging: fbtft: Allows bpp to be set " Radoslaw Pietrzyk
2017-03-12 14:27   ` Greg KH [this message]
2017-03-12 22:12   ` kbuild test robot
2017-03-13 10:28   ` [PATCH v2] " Radoslaw Pietrzyk
2017-03-13 11:00     ` Dan Carpenter
2017-03-13 11:07       ` Radosław Pietrzyk
2017-03-13 11:11         ` Dan Carpenter
2017-03-13 11:16           ` Radosław Pietrzyk
2017-03-13 11:19             ` Dan Carpenter
2017-03-13 11:21               ` Radosław Pietrzyk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170312142734.GA19066@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=radoslaw.pietrzyk@gmail.com \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome