From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932076AbdCMWcs (ORCPT ); Mon, 13 Mar 2017 18:32:48 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:58336 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752553AbdCMWci (ORCPT ); Mon, 13 Mar 2017 18:32:38 -0400 Date: Mon, 13 Mar 2017 15:32:36 -0700 (PDT) Message-Id: <20170313.153236.1183838776173721070.davem@davemloft.net> To: linux@roeck-us.net Cc: steve.glendinning@shawell.net, UNGLinuxDriver@microchip.com, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usbnet: smsc95xx: Reduce logging noise From: David Miller In-Reply-To: <1489196721-12888-1-git-send-email-linux@roeck-us.net> References: <1489196721-12888-1-git-send-email-linux@roeck-us.net> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 13 Mar 2017 15:32:37 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Guenter Roeck Date: Fri, 10 Mar 2017 17:45:21 -0800 > An insert/remove stress test generated the following log message sequence. ... > Use netdev_dbg() instead of netdev_warn() for the repeating messages > to reduce logging noise. > > Signed-off-by: Guenter Roeck The problem I have with changes like this is that outside of your stress test situation these messages are extremely useful but will now be hidden making diagnosis of problems more difficult. Perhaps you can check the error code or some piece of USB device state to see if there was a disconnect, and elide the log message in that case specifically. Thanks.