From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750839AbdCMFVy (ORCPT ); Mon, 13 Mar 2017 01:21:54 -0400 Received: from mga07.intel.com ([134.134.136.100]:15224 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750756AbdCMFVr (ORCPT ); Mon, 13 Mar 2017 01:21:47 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,157,1486454400"; d="scan'208";a="235287989" Date: Mon, 13 Mar 2017 08:21:13 +0300 From: "Kirill A. Shutemov" To: Chris Packham Cc: linux-mm@kvack.org, mhocko@suse.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: mark gup_pud_range as unused Message-ID: <20170313052113.4mgqf7a6vsfyeocg@black.fi.intel.com> References: <20170313035837.29719-1-chris.packham@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170313035837.29719-1-chris.packham@alliedtelesis.co.nz> User-Agent: NeoMutt/20161126 (1.7.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 13, 2017 at 04:58:37PM +1300, Chris Packham wrote: > The last caller to gup_pud_range was removed in commit c2febafc6773 > ("mm: convert generic code to 5-level paging"). Mark it as unused to > silence a warning from gcc. > > Signed-off-by: Chris Packham > --- > I saw this warning when compiling 4.11-rc2 with -Werror. An equally valid fix > would be to remove the function entirely but I went for the less invasive > approach. Thanks for report. But real fix is to call gup_pud_range() from gup_p4d_range(), not itself. I'll post a fix. Reported-by: Chris Packham Reported-by: Chris Packham -- Kirill A. Shutemov