From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753917AbdCMQHU (ORCPT ); Mon, 13 Mar 2017 12:07:20 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:56394 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752500AbdCMQHG (ORCPT ); Mon, 13 Mar 2017 12:07:06 -0400 From: Arnd Bergmann To: Marcel Holtmann , Gustavo Padovan , Johan Hedberg Cc: Arnd Bergmann , Bjorn Andersson , Javier Martinez Canillas , Loic Poulain , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RESEND PATCH] Bluetooth: btqcomsmd: fix compile-test dependency Date: Mon, 13 Mar 2017 17:06:21 +0100 Message-Id: <20170313160635.612251-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:mrHfTmjNQRJ738l45TheeLjQJv4qhZWWUsJeHitOpkYNRsmiHoV M4PQ9CTd5uH3E4v6+sNK2wEYC94oeAQ48XOxlJSk7cQFlrVfj2Kws5jbbNSdcNb9uft8ADq 16YgUS0pg9hJn03HcilXMi2mx9zup6LH5iPFCRALCP0PoNs9c1J/pSZB/YH4HnI1K3ou3oL P4KEfbPTvm/w9RvluS+gw== X-UI-Out-Filterresults: notjunk:1;V01:K0:TVjAHGJKqM4=:OERVUcFn1LBcddJpEsWxcD kr4NdQPDMBSP71050TUf8ZViSNcI4u3TAt552TAHr0W2NmWroboHNkqyXPI7zvY0FOMV0H5a9 9ty+8Ck7ple7idw2r3PgEpnUAxTDEQ3ydNtUQ+SE39ydw2VOcm1C4Zx/BIawV6pEyd3ciV0ce 6BXobz/RLh9XRmDXYvqsu7hr88YWGig7+MYx3vG50H/CzMVprI5Uke+OezfmYR61JAwUpt3OK daN2Ww4isyDdT9NpvkMX1xR0XjNhSXXIOKwUzCN1pEdlkBJoKQdVlnVA3k8jwOyKrYVsZcg96 QeW7TjS8ljTIJaf7uKjKN6vw2h8d4gICzTOZHfWZIDs1pS9N85vbWCXXrzuQomkQ6Hsy1BLjD HUeFZE0ZXkpSKc/8CcB9OnrvYTfV7VqCgyAqLxXeg6R3DMcovacW/ht8QMey426vDq/VYoMaN JFVArHCi1BhRVT5+9tI8Ew6slA585W0EUa6FzgXsjcltEgB/FckI9K54Kynp/ZpUkManeT96u U3GEAhVvpTxp93NGtiUWp0VzLxDDXKAFzmUm/AWW1i3eWxF19jk52Tx9oQ2q/MeXXuijBfjTg Vy/XuT3DfO3omDlu71oX64/TNo+mRvUoSeYmK5DFG+EFAfwrytOvfINdGRYmLgH2phBKvMUKD mBKdg1rMoK95lhysS/0PAJOJ+aEZMHLF0ipWT+Z86zKAiLUpApCf0kYGmaUZibytDXHk= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org compile-testing fails when QCOM_SMD is a loadable module: drivers/bluetooth/built-in.o: In function `btqcomsmd_send': btqca.c:(.text+0xa8): undefined reference to `qcom_smd_send' drivers/bluetooth/built-in.o: In function `btqcomsmd_probe': btqca.c:(.text+0x3ec): undefined reference to `qcom_wcnss_open_channel' btqca.c:(.text+0x46c): undefined reference to `qcom_smd_set_drvdata' This clarifies the dependency to allow compile-testing only when SMD is completely disabled, otherwise the dependency on QCOM_SMD will make sure we can link against it. Fixes: e27ee2b16bad ("Bluetooth: btqcomsmd: Allow driver to build if COMPILE_TEST is enabled") Signed-off-by: Arnd Bergmann Reviewed-by: Javier Martinez Canillas --- Sent on March 1 2017 originally, still needed for v4.11-rc2 --- drivers/bluetooth/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig index c2c14a12713b..2ef2b240b31b 100644 --- a/drivers/bluetooth/Kconfig +++ b/drivers/bluetooth/Kconfig @@ -344,7 +344,7 @@ config BT_WILINK config BT_QCOMSMD tristate "Qualcomm SMD based HCI support" - depends on (QCOM_SMD && QCOM_WCNSS_CTRL) || COMPILE_TEST + depends on (QCOM_SMD && QCOM_WCNSS_CTRL) || (COMPILE_TEST && QCOM_SMD=n) select BT_QCA help Qualcomm SMD based HCI driver. -- 2.9.0