From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754514AbdCMRRo (ORCPT ); Mon, 13 Mar 2017 13:17:44 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:44317 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753607AbdCMRRg (ORCPT ); Mon, 13 Mar 2017 13:17:36 -0400 Date: Mon, 13 Mar 2017 10:17:13 -0700 From: Guenter Roeck To: Arnd Bergmann Cc: Andrew Morton , Wim Van Sebroeck , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH] watchdog: orion: fix compile-test dependencies Message-ID: <20170313171713.GC16813@roeck-us.net> References: <20170313164105.1038960-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170313164105.1038960-1-arnd@arndb.de> User-Agent: Mutt/1.5.24 (2015-08-30) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 13, 2017 at 05:40:48PM +0100, Arnd Bergmann wrote: > I ran into one corner case with the orion watchdog using the > atomic_io_modify interface: > > drivers/watchdog/orion_wdt.o: In function `orion_stop': > orion_wdt.c:(.text.orion_stop+0x28): undefined reference to `atomic_io_modify' > drivers/watchdog/orion_wdt.o: In function `armada375_stop': > orion_wdt.c:(.text.armada375_stop+0x28): undefined reference to `atomic_io_modify' > > This function is available on all 32-bit ARM builds except for ebsa110, so > we have to specifically exclude that from compile-testing. > > Fixes: da2a68b3eb47 ("watchdog: Enable COMPILE_TEST where possible") > Signed-off-by: Arnd Bergmann > Reviewed-by: Guenter Roeck I have it queued up in my patch list. Just need to sort out with Wim how to send it upstream. Guenter > --- > Originally submitted on March 2, still needed to address the one remaining > kernelci.org build failure in v4.11-rc2: > > https://kernelci.org/build/id/58c5dbdc59b514108e645533/ > --- > drivers/watchdog/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index 52a70ee6014f..8b9049dac094 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -452,7 +452,7 @@ config DAVINCI_WATCHDOG > > config ORION_WATCHDOG > tristate "Orion watchdog" > - depends on ARCH_ORION5X || ARCH_DOVE || MACH_DOVE || ARCH_MVEBU || COMPILE_TEST > + depends on ARCH_ORION5X || ARCH_DOVE || MACH_DOVE || ARCH_MVEBU || (COMPILE_TEST && !ARCH_EBSA110) > depends on ARM > select WATCHDOG_CORE > help > -- > 2.9.0 >