mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Matthew Giassa <matthew@giassa.net>
Cc: wsa@the-dreams.de, linux-renesas-soc@vger.kernel.org,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Formatting updates to remove checkpatch warnings in ks_wlan_ioctl.h.
Date: Tue, 14 Mar 2017 05:53:34 +0800	[thread overview]
Message-ID: <20170313215333.GA13395@kroah.com> (raw)
In-Reply-To: <1488750740-2091-1-git-send-email-matthew@giassa.net>

On Sun, Mar 05, 2017 at 01:52:19PM -0800, Matthew Giassa wrote:
> Implementing some minor formatting changes to remove checkpatch warnings.
> Removing space-hardtab instances. Removing C++-style line comments in favor of
> C-style equivalent. Re-aligning function prototype arguments to remove related
> checkpatch warning.

That is a lot of different things to do all at once, please break this
up into one logical patch per "thing" you do.

Also, fix up your subject line to match how other patches for this
subsystem/driver look, git log will show you what to do there.

thanks,

greg k-h

      parent reply	other threads:[~2017-03-13 21:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-05 21:52 Matthew Giassa
2017-03-05 21:52 ` [PATCH 2/2] Formatting updates to resolve checkpatch errors " Matthew Giassa
2017-03-13 21:53 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170313215333.GA13395@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=matthew@giassa.net \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome