From: Steven Rostedt <rostedt@goodmis.org>
To: Qi Hou <qi.hou@windriver.com>
Cc: <mingo@redhat.com>, <tglx@linutronix.de>,
<linux-kernel@vger.kernel.org>, <C.Emde@osadl.org>,
<paul.gortmaker@windriver.com>, <bruce.ashfield@windriver.com>
Subject: Re: [PATCH] lockdep: call time_hardirqs_off after clearing hardirqs_enabled
Date: Mon, 13 Mar 2017 23:04:42 -0400 [thread overview]
Message-ID: <20170313230442.17705320@grimm.local.home> (raw)
In-Reply-To: <1489456807-160132-1-git-send-email-qi.hou@windriver.com>
On Tue, 14 Mar 2017 10:00:07 +0800
Qi Hou <qi.hou@windriver.com> wrote:
> diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
> index 577f026..e8b35e4 100644
> --- a/kernel/locking/lockdep.c
> +++ b/kernel/locking/lockdep.c
> @@ -2627,8 +2627,6 @@ __visible void trace_hardirqs_off_caller(unsigned long ip)
> {
> struct task_struct *curr = current;
>
> - time_hardirqs_off(CALLER_ADDR0, ip);
> -
> if (unlikely(!debug_locks || current->lockdep_recursion))
> return;
You do realize that this breaks irqsoff tracing if lockdep ever
triggers. Right?
-- Steve
>
> @@ -2649,6 +2647,8 @@ __visible void trace_hardirqs_off_caller(unsigned long ip)
> debug_atomic_inc(hardirqs_off_events);
> } else
> debug_atomic_inc(redundant_hardirqs_off);
> +
> + time_hardirqs_off(CALLER_ADDR0, ip);
> }
> EXPORT_SYMBOL(trace_hardirqs_off_caller);
>
next prev parent reply other threads:[~2017-03-14 3:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 2:00 Qi Hou
2017-03-14 3:03 ` Paul Gortmaker
2017-03-14 3:04 ` Steven Rostedt [this message]
2017-03-14 8:44 ` Thomas Gleixner
2017-03-14 9:16 ` qhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170313230442.17705320@grimm.local.home \
--to=rostedt@goodmis.org \
--cc=C.Emde@osadl.org \
--cc=bruce.ashfield@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paul.gortmaker@windriver.com \
--cc=qi.hou@windriver.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®