From: Masaki Ota <012nexus@gmail.com>
To: dmitry.torokhov@gmail.com, linux-kernel@paulsd.com,
nick.m.fletcher@gmail.com
Cc: joseph.salisbury@canonical.com, ben@smart-cactus.org,
mhocko@suse.com, pali.rohar@gmail.com, rydberg@bitmath.org,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
masaki.ota@jp.alps.com
Subject: [PATCH 2/2] Fix the issue that V8 Button pad Stick button does not work
Date: Tue, 14 Mar 2017 10:34:13 +0900 [thread overview]
Message-ID: <20170314013413.7260-2-masaki.ota@jp.alps.com> (raw)
In-Reply-To: <20170314013413.7260-1-masaki.ota@jp.alps.com>
From: Masaki Ota <masaki.ota@jp.alps.com>
- V8 Button pad Stick Right and Middle button don't work.
- Alps stick devices have physical buttons absolutely, so delete "ALPS_BUTTONPAD" check Flag from Stick button process.
Signed-off-by: Masaki Ota <masaki.ota@jp.alps.com>
Acked-by: Pali Rohar <pali.rohar@gmail.com>
---
drivers/input/mouse/alps.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
index 253f742..262d105 100644
--- a/drivers/input/mouse/alps.c
+++ b/drivers/input/mouse/alps.c
@@ -1287,10 +1287,8 @@ static int alps_decode_ss4_v2(struct alps_fields *f,
/* handle buttons */
if (pkt_id == SS4_PACKET_ID_STICK) {
f->ts_left = !!(SS4_BTN_V2(p) & 0x01);
- if (!(priv->flags & ALPS_BUTTONPAD)) {
- f->ts_right = !!(SS4_BTN_V2(p) & 0x02);
- f->ts_middle = !!(SS4_BTN_V2(p) & 0x04);
- }
+ f->ts_right = !!(SS4_BTN_V2(p) & 0x02);
+ f->ts_middle = !!(SS4_BTN_V2(p) & 0x04);
} else {
f->left = !!(SS4_BTN_V2(p) & 0x01);
if (!(priv->flags & ALPS_BUTTONPAD)) {
--
2.9.3
next prev parent reply other threads:[~2017-03-14 1:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 1:34 [PATCH 1/2] Fix V8 device information issue Masaki Ota
2017-03-14 1:34 ` Masaki Ota [this message]
2017-03-14 14:51 ` [PATCH 2/2] Fix the issue that V8 Button pad Stick button does not work Paul Donohue
2017-03-17 21:26 ` Dmitry Torokhov
2017-03-14 14:50 ` [PATCH 1/2] Fix V8 device information issue Paul Donohue
2017-03-17 21:26 ` Dmitry Torokhov
2017-04-12 16:00 ` Dmitry Torokhov
-- strict thread matches above, loose matches on Subject: below --
2017-03-13 7:04 Masaki Ota
2017-03-13 7:04 ` [PATCH 2/2] Fix the issue that V8 Button pad Stick button does not work Masaki Ota
2017-03-13 14:39 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170314013413.7260-2-masaki.ota@jp.alps.com \
--to=012nexus@gmail.com \
--cc=ben@smart-cactus.org \
--cc=dmitry.torokhov@gmail.com \
--cc=joseph.salisbury@canonical.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@paulsd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masaki.ota@jp.alps.com \
--cc=mhocko@suse.com \
--cc=nick.m.fletcher@gmail.com \
--cc=pali.rohar@gmail.com \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®