From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754548AbdCNDFi (ORCPT ); Mon, 13 Mar 2017 23:05:38 -0400 Received: from mail-pg0-f51.google.com ([74.125.83.51]:33901 "EHLO mail-pg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753757AbdCNDFf (ORCPT ); Mon, 13 Mar 2017 23:05:35 -0400 Date: Tue, 14 Mar 2017 08:35:31 +0530 From: Viresh Kumar To: Kevin Hilman Cc: Ulf Hansson , Rafael Wysocki , Len Brown , Pavel Machek , linaro-kernel , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Vincent Guittot Subject: Re: [PATCH] PM / QOS: Remove the global notifiers Message-ID: <20170314030531.GC3102@vireshk-i7> References: <8361bf69d667d7092c2b3b0ecabf147c7324ec33.1487752071.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13-03-17, 14:32, Kevin Hilman wrote: > Ulf Hansson writes: > > > On 13 March 2017 at 17:01, Ulf Hansson wrote: > >> On 22 February 2017 at 09:28, Viresh Kumar wrote: > >>> They were never used in the kernel, not sure why they got merged into > >>> the kernel though. Get rid of them. > >> > >> commit b66213cdb002b08b29603d488c451dfe25e2ca20 > >> Author: Jean Pihet > >> Date: Thu Aug 25 15:35:47 2011 +0200 > >> > >> PM QoS: Add global notification mechanism for device constraints > >> > >> Add a global notification chain that gets called upon changes to the > >> aggregated constraint value for any device. > >> The notification callbacks are passing the full constraint request data > >> in order for the callees to have access to it. The current use is for the > >> platform low-level code to access the target device of the constraint. > >> > >> Signed-off-by: Jean Pihet > >> Reviewed-by: Kevin Hilman > >> Signed-off-by: Rafael J. Wysocki > >> > >> It was a while ago since they were added, but it seems like > > > > Slipped on the keyboard, sorry for the noise. > > > > I was about to say, that it was a while ago these were added, but > > still not being used. Thus let's remove them. > > > > Acked-by: Ulf Hansson > > Agreed. If we still have no users, let's remove them. > > Acked-by: Kevin Hilman Its in Linus's tree for sometime now :) Thanks for your Acks though -- viresh