From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750852AbdCNKEV (ORCPT ); Tue, 14 Mar 2017 06:04:21 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:38706 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750749AbdCNKET (ORCPT ); Tue, 14 Mar 2017 06:04:19 -0400 Date: Tue, 14 Mar 2017 10:04:15 +0000 From: Lee Jones To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mfd: retu: Add OF device ID table Message-ID: <20170314100415.mwjm76lkskmtkpv3@dell> References: <20170221133435.25881-1-javier@osg.samsung.com> <096d8b8a-7429-a61e-dbc0-b74309d131e0@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <096d8b8a-7429-a61e-dbc0-b74309d131e0@osg.samsung.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 10 Mar 2017, Javier Martinez Canillas wrote: > Hello Lee, > > On 02/21/2017 10:34 AM, Javier Martinez Canillas wrote: > > The driver doesn't have a struct of_device_id table but supported devices > > are registered via Device Trees. This is working on the assumption that a > > I2C device registered via OF will always match a legacy I2C device ID and > > that the MODALIAS reported will always be of the form i2c:. > > > > But this could change in the future so the correct approach is to have a > > OF device ID table if the devices are registered via OF. > > > > The compatible strings don't have a vendor prefix because that's how it's > > used currently, and changing this will be a Device Tree ABI break. > > > > Signed-off-by: Javier Martinez Canillas > > --- > > Any comment on this patch and 2/2? Apologies, I've been on vacation. Will get to it in due course. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog