From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751048AbdCNMyo (ORCPT ); Tue, 14 Mar 2017 08:54:44 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:65076 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750795AbdCNMyn (ORCPT ); Tue, 14 Mar 2017 08:54:43 -0400 From: Arnd Bergmann To: Thomas Gleixner , Jason Cooper , Marc Zyngier Cc: Arnd Bergmann , Thomas Petazzoni , linux-kernel@vger.kernel.org Subject: [RESEND PATCH] irqchip: mvebu-odmi: select GENERIC_MSI_IRQ_DOMAIN Date: Tue, 14 Mar 2017 13:54:12 +0100 Message-Id: <20170314125427.696234-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:X40Tqk4p6P0N2NS4pHRFPrnr05i+2oBeKEk7OJW9Nkj7cL9ZKDO hpKs8egG9Ld5dQcECXqDu6zJG8RXlcOGXGM0ikyia/es64JdzfzcUJFjvOhkb6iyuwBN0R0 XR4bqLi/nECmmdMsjQ7VgPZQM0DrWkgKAwo1usy28IWqiO9v1XksQTz6uHAUgzflCqOKlVE X2vKpgcZZ5MzRxnVf4FBw== X-UI-Out-Filterresults: notjunk:1;V01:K0:wqCLAwkxmjo=:nIS6iDDDNktYqlKwALcHB+ OduUzeVMeySzSE1oXUuhvVAOh5BEUtzjyDhIfeXPXWKIeaegvP3Woc7yCJyfuPVqZ2X1RiaTi bVd6i9R/o3MhhkhWzIk0JhL+vMg+iN71GoBezNq0U/aC1AY5B8+R8ETHb9UWqlIs63BUy1w9G Tozan6bo2spdcH/0F01SvCdmyA+LaRAH3RJD146kZch9URQr4X+QBzsAeExw73FChGOoOJyvP FGZlf05f6HA0wDrSeaa1zAIPsbu1KjQ/CGXckXlx3IyRfSL8v/Rw672K0xH+M+cIeNCSm8QCH +ZTJLXzJOojlFFSkZJjtRZS90zsIIjEmQKKtx7iJNBXL8dR9ceqCYF8bi/9W0iQtff0JrsLQH Vzw2LSfLOAhYPvpf3g+fdsT0LVf6ekJojASaLeGbjYWaBBpJCfm/43L+s5iMDuKRByGmiVyyn 65SfzmBc1UeO2slplnxD8YsJx3rclxO+yv6Lly36NH4/Xv56jEQ0UZyMD94Q+cvytcaSVeBnt f09QP2FE6aT7iPk6EgszAXR+Ts0zUT0H7+1PHwOUtkDwRy920irs7rrOccEbD6P3Tvtxi/UI3 sezFaqjuQvLzt+ifgD5SSOGWODBCXkShEsTJ4b5guu7B2gTr10CcUwwbbWSSiMHtE2OOwRq6M 40GjPG8MRtGydHgSCuKxxc/9EAExFnP7Zfzmke7tf7OVlHh39S0J8rSlDks0qgsWhdLM= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This driver uses the MSI domain but has no strict dependency on PCI_MSI, so we may run into a build failure when CONFIG_GENERIC_MSI_IRQ_DOMAIN is disabled: drivers/irqchip/irq-mvebu-odmi.c:152:15: error: variable 'odmi_msi_ops' has initializer but incomplete type static struct msi_domain_ops odmi_msi_ops = { ^~~~~~~~~~~~~~ drivers/irqchip/irq-mvebu-odmi.c:155:15: error: variable 'odmi_msi_domain_info' has initializer but incomplete type static struct msi_domain_info odmi_msi_domain_info = { ^~~~~~~~~~~~~~~ drivers/irqchip/irq-mvebu-odmi.c:156:3: error: 'struct msi_domain_info' has no member named 'flags' .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS), ^~~~~ drivers/irqchip/irq-mvebu-odmi.c:156:12: error: 'MSI_FLAG_USE_DEF_DOM_OPS' undeclared here (not in a function) .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS), ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/irqchip/irq-mvebu-odmi.c:156:39: error: 'MSI_FLAG_USE_DEF_CHIP_OPS' undeclared here (not in a function); did you mean 'MSI_FLAG_USE_DEF_DOM_OPS'? Selecting the option from this driver seems to solve this nicely, though I could not find any other instance of this in irqchip drivers. Signed-off-by: Arnd Bergmann Acked-by: Thomas Petazzoni --- Originally sent on Feb 14, but for some reason didn't make it into v4.11-rc2 and is still needed to build some randconfig configurations. --- drivers/irqchip/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig index 125528f39e92..8162121bb1bc 100644 --- a/drivers/irqchip/Kconfig +++ b/drivers/irqchip/Kconfig @@ -262,6 +262,7 @@ config IRQ_MXS config MVEBU_ODMI bool + select GENERIC_MSI_IRQ_DOMAIN config MVEBU_PIC bool -- 2.9.0