From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751547AbdCNM6a (ORCPT ); Tue, 14 Mar 2017 08:58:30 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:57348 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751315AbdCNM62 (ORCPT ); Tue, 14 Mar 2017 08:58:28 -0400 From: Arnd Bergmann To: Linus Walleij , Alexandre Courbot Cc: Arnd Bergmann , Axel Lin , Duc Dang , Paul Gortmaker , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RESEND PATCH] gpio: xgene: mark PM functions as __maybe_unused Date: Tue, 14 Mar 2017 13:57:38 +0100 Message-Id: <20170314125748.734574-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:FqWK2GEXa2wwwOW0St60ohcKtrRGn/aLWxt4TKHlMybSvhMvu9q logmXcTvu6z98/Z53Wu6Pp8CypT5UfsZIaaXJFrGqYE2yWIe5wM+uyl8K79w3nuKQeP1EjN 9kjmvGg+OGas5x6qIoLxazBwrBCRnPzp7+f2wr8LJO3d8nYw+Qe2lMTGHJ/R9vIS0rbJROz MOYGwh52GyNOhtFR/DN1Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:KzOYyrgs+FA=:iyNeUZLCeCEkVx0EmYsPpv fFxFCfi9hmXZYaasWE27OVRPRtTwo09wE1jPrIalD06AXy24jA4r6df9mJ9ll5kCTyVN/Mr1Z +yU1GXnMgaDlF7k0Jd3SBsX1MSkpBBsqP5hLPMYW0uokJyiBvh3tthMBOPME/sNDmeAPFkG/b bgSeidhqDfFQM5FjQ4y4uCacSzT60/Y6qlUqQj8Fd1nVOJJ+VCUiMix+qhjDRJ5XCR4bRgcMb Tlue8gKiKXZFD46OKpKpvc4GYe6qbwA2vxcpjRqDBtAWavwvdqMUcFhNl+92ZhFADGPWVotTV K6rPZ6ZRpsurVeToMxKZRQAMvjB/tB8WMH906dlEaUR3BwXBu4UMYpEg5sLBCEMBXLbp4g/rK k/zrTmamstzuDnEvk/4pYZph1r8Ij5n3IU1FVcAZvcPpjyL9NZG+YVD8gK7BrKtrVjI+wtLts nFPuRHtu4hsfgruo7W4xd4A9Wz9dtCMOuZ+05tfEP/0s1Qj6re16//6UN1Q0UWKSSaXGag9sw oBtCv4ENMwlX2OKVyCHcTOrXpFa3v0OGGoWvgHHaa/Kcuz+XlubnTB+bzSW8Wt4/0j1tKSzeF v059GfXIvkuV1TUWx20a8KNQGNZkZZeIS31FMGC3B/3F/1w+oG7p3/3D8/fkiao6BBc43oHAg FE9OJOu8VtsKft34vEAPJNql5iCFPCMSLkSRZqVINVExdfaoL7ktQ9o1HIAJws1CQlko= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When CONFIG_PM_SLEEP is disabled, we get a warning about unused functions: drivers/gpio/gpio-xgene.c:155:12: warning: 'xgene_gpio_resume' defined but not used [-Wunused-function] static int xgene_gpio_resume(struct device *dev) ^~~~~~~~~~~~~~~~~ drivers/gpio/gpio-xgene.c:142:12: warning: 'xgene_gpio_suspend' defined but not used [-Wunused-function] static int xgene_gpio_suspend(struct device *dev) The warnings are harmless and can be avoided by simplifying the code and marking the functions as __maybe_unused. Signed-off-by: Arnd Bergmann --- Originally submitted on Feb 17, but it ended up not getting merged into v4.11-rc2 and is still needed there for randconfig builds --- drivers/gpio/gpio-xgene.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/gpio/gpio-xgene.c b/drivers/gpio/gpio-xgene.c index 40a8881c2ce8..f1c6ec17b90a 100644 --- a/drivers/gpio/gpio-xgene.c +++ b/drivers/gpio/gpio-xgene.c @@ -42,9 +42,7 @@ struct xgene_gpio { struct gpio_chip chip; void __iomem *base; spinlock_t lock; -#ifdef CONFIG_PM u32 set_dr_val[XGENE_MAX_GPIO_BANKS]; -#endif }; static int xgene_gpio_get(struct gpio_chip *gc, unsigned int offset) @@ -138,8 +136,7 @@ static int xgene_gpio_dir_out(struct gpio_chip *gc, return 0; } -#ifdef CONFIG_PM -static int xgene_gpio_suspend(struct device *dev) +static __maybe_unused int xgene_gpio_suspend(struct device *dev) { struct xgene_gpio *gpio = dev_get_drvdata(dev); unsigned long bank_offset; @@ -152,7 +149,7 @@ static int xgene_gpio_suspend(struct device *dev) return 0; } -static int xgene_gpio_resume(struct device *dev) +static __maybe_unused int xgene_gpio_resume(struct device *dev) { struct xgene_gpio *gpio = dev_get_drvdata(dev); unsigned long bank_offset; @@ -166,10 +163,6 @@ static int xgene_gpio_resume(struct device *dev) } static SIMPLE_DEV_PM_OPS(xgene_gpio_pm, xgene_gpio_suspend, xgene_gpio_resume); -#define XGENE_GPIO_PM_OPS (&xgene_gpio_pm) -#else -#define XGENE_GPIO_PM_OPS NULL -#endif static int xgene_gpio_probe(struct platform_device *pdev) { @@ -241,7 +234,7 @@ static struct platform_driver xgene_gpio_driver = { .name = "xgene-gpio", .of_match_table = xgene_gpio_of_match, .acpi_match_table = ACPI_PTR(xgene_gpio_acpi_match), - .pm = XGENE_GPIO_PM_OPS, + .pm = &xgene_gpio_pm, }, .probe = xgene_gpio_probe, }; -- 2.9.0