From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753191AbdCOKMV (ORCPT ); Wed, 15 Mar 2017 06:12:21 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:38506 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752651AbdCOKMT (ORCPT ); Wed, 15 Mar 2017 06:12:19 -0400 Date: Wed, 15 Mar 2017 10:12:15 +0000 From: Lee Jones To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mfd: intel_soc_pmic: Fix a mess with compilation units Message-ID: <20170315101215.svmi4tyzyql2bze5@dell> References: <20170313190727.8069-1-andriy.shevchenko@linux.intel.com> <20170314150234.z4omelqdwox5tts4@dell> <1489504914.20145.247.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1489504914.20145.247.camel@linux.intel.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 14 Mar 2017, Andy Shevchenko wrote: > On Tue, 2017-03-14 at 15:02 +0000, Lee Jones wrote: > > On Mon, 13 Mar 2017, Andy Shevchenko wrote: > > > > > Crystal Cove and Whiskey Cove are two different PMICs which are > > > installed on Intel Atom SoC based platforms. > > > > > > Moreover there are two independent drivers that by some reason are > > > supposed (*) to get into one kernel module. > > > > > > Fix the mess by clarifying Kconfig option for Crystal Cove and split > > > Whiskey Cove out of it. > > > > > > (*) It looks like the configuration was never ever tested. The line > > > in > > >     Makefile is actually wrong. >   > > >  config INTEL_SOC_PMIC > > > - bool "Support for Intel Atom SoC PMIC" > > > + bool "Support for Crystal Cove PMIC" > > >   depends on GPIOLIB > > >   depends on I2C=y > > >   select MFD_CORE > > >   select REGMAP_I2C > > >   select REGMAP_IRQ > > >   help > > > -   Select this option to enable support for the PMIC device > > > +   Select this option to enable support for Crystal Cove > > > PMIC > > >     on some Intel SoC systems. The PMIC provides ADC, GPIO, > > >     thermal, charger and related power management functions > > >     on these systems. > > >   > > > +config INTEL_SOC_PMIC_BXTWC > > > + tristate > > > + select MFD_CORE > > > + select REGMAP_IRQ > > > > I think you need to make mention that this is Whiskey Cove? > > It's selectable option, so I don't know if it's a good idea to make it > visible to the user. Or do you mean fill the help section only? I think you just answered your own question. :) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog