From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753707AbdCOLE0 (ORCPT ); Wed, 15 Mar 2017 07:04:26 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:33290 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752117AbdCOLDT (ORCPT ); Wed, 15 Mar 2017 07:03:19 -0400 Date: Wed, 15 Mar 2017 11:03:15 +0000 From: Lee Jones To: Elaine Zhang Cc: lgirdwood@gmail.com, broonie@kernel.org, huangtao@rock-chips.com, xxx@rock-chips.com, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, chenjh@rock-chips.com, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, w.egorov@phytec.de Subject: Re: [PATCH v2 4/5] mfd: rk808: Add RK805 support Message-ID: <20170315110315.dekx7nhb66dmgxxe@dell> References: <1489111252-22175-1-git-send-email-zhangqing@rock-chips.com> <1489111252-22175-5-git-send-email-zhangqing@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1489111252-22175-5-git-send-email-zhangqing@rock-chips.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 10 Mar 2017, Elaine Zhang wrote: > The RK805 chip is a Power Management IC (PMIC) for multimedia and handheld > devices. It contains the following components: > > - Regulators > - RTC > - Clocking > > Both RK808 and RK805 chips are using a similar register map, > so we can reuse the RTC and Clocking functionality. > > Signed-off-by: Elaine Zhang > --- > drivers/clk/Kconfig | 4 +- Acked-by: Lee Jones > drivers/mfd/Kconfig | 4 +- > drivers/mfd/rk808.c | 117 ++++++++++++++++++++++++++++++++++++++++++++++++++++ Comments below. > drivers/rtc/Kconfig | 4 +- Acked-by: Lee Jones > 4 files changed, 123 insertions(+), 6 deletions(-) Split this patch up into subsystems, it'll save issues. [...] > --- a/drivers/mfd/rk808.c > +++ b/drivers/mfd/rk808.c [...] > +static void rk805_device_shutdown(void) > +{ > + int ret; > + struct rk808 *rk808 = i2c_get_clientdata(rk808_i2c_client); > + > + if (!rk808) { > + dev_warn(&rk808_i2c_client->dev, > + "have no rk808, so do nothing here\n"); > + return; > + } > + > + /* close rtc int when power off */ > + regmap_update_bits(rk808->regmap, > + RK808_INT_STS_MSK_REG1, > + (0x3 << 5), (0x3 << 5)); No magic numbers. Please define these. > + regmap_update_bits(rk808->regmap, > + RK808_RTC_INT_REG, > + (0x3 << 2), (0x0 << 2)); No magic numbers. Please define these. > + > + /* pmic sleep shutdown function */ > + ret = regmap_update_bits(rk808->regmap, > + RK805_GPIO_IO_POL_REG, > + SLP_SD_MSK, SHUTDOWN_FUN); > + if (ret) > + dev_err(&rk808_i2c_client->dev, "power off error!\n"); > +} -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog