From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754114AbdCOPk0 (ORCPT ); Wed, 15 Mar 2017 11:40:26 -0400 Received: from mail.kernel.org ([198.145.29.136]:33528 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753162AbdCOPkX (ORCPT ); Wed, 15 Mar 2017 11:40:23 -0400 Date: Wed, 15 Mar 2017 11:40:17 -0400 From: Steven Rostedt To: Jiri Slaby Cc: mingo@redhat.com, linux-kernel@vger.kernel.org, Thomas Gleixner , "H. Peter Anvin" , x86@kernel.org, Frederic Weisbecker Subject: Re: [PATCH 1/1] fentry: x86, cleanup function_hook uses Message-ID: <20170315114017.30eb3c31@gandalf.local.home> In-Reply-To: <20170315134436.23674-1-jslaby@suse.cz> References: <20170315134436.23674-1-jslaby@suse.cz> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Mar 2017 14:44:36 +0100 Jiri Slaby wrote: > @@ -16,14 +17,6 @@ > > #ifdef CONFIG_FUNCTION_TRACER > > -#ifdef CC_USING_FENTRY > -# define function_hook __fentry__ > -EXPORT_SYMBOL(__fentry__) There's a reason the export symbols are here. > -#else > -# define function_hook mcount > -EXPORT_SYMBOL(mcount) > -#endif > - > /* All cases save the original rbp (8 bytes) */ > #ifdef CONFIG_FRAME_POINTER > # ifdef CC_USING_FENTRY > @@ -297,6 +290,7 @@ trace: > jmp fgraph_trace > END(function_hook) > #endif /* CONFIG_DYNAMIC_FTRACE */ > +EXPORT_SYMBOL(function_hook) Under certain configs, this will fail the build. EXPORT_SYMBOL() does not take the function_hook as a macro nicely. See commit 5de0a8c0c24033. -- Steve > #endif /* CONFIG_FUNCTION_TRACER */ > > #ifdef CONFIG_FUNCTION_GRAPH_TRACER