From: Steven Rostedt <rostedt@goodmis.org>
To: Jiri Slaby <jslaby@suse.cz>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH 1/1] fentry: x86, cleanup function_hook uses
Date: Wed, 15 Mar 2017 11:58:12 -0400 [thread overview]
Message-ID: <20170315115812.07ab384d@gandalf.local.home> (raw)
In-Reply-To: <5110276c-7a4f-77b9-6ffb-efcfa4734b60@suse.cz>
On Wed, 15 Mar 2017 16:49:54 +0100
Jiri Slaby <jslaby@suse.cz> wrote:
> On 03/15/2017, 04:40 PM, Steven Rostedt wrote:
> >> -#else
> >> -# define function_hook mcount
> >> -EXPORT_SYMBOL(mcount)
> >> -#endif
> >> -
> >> /* All cases save the original rbp (8 bytes) */
> >> #ifdef CONFIG_FRAME_POINTER
> >> # ifdef CC_USING_FENTRY
> >> @@ -297,6 +290,7 @@ trace:
> >> jmp fgraph_trace
> >> END(function_hook)
> >> #endif /* CONFIG_DYNAMIC_FTRACE */
> >> +EXPORT_SYMBOL(function_hook)
> >
> > Under certain configs, this will fail the build. EXPORT_SYMBOL() does
> > not take the function_hook as a macro nicely. See commit 5de0a8c0c24033.
>
> Ok, thanks, forget about it then. I had the patch in my tree since Feb 3
> 2014, so I can finally drop it...
>
>
Great, cause I'm currently cleaning up that code too, and this would
cause conflicts ;-)
-- Steve
next prev parent reply other threads:[~2017-03-15 15:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 13:44 Jiri Slaby
2017-03-15 15:40 ` Steven Rostedt
2017-03-15 15:49 ` Jiri Slaby
2017-03-15 15:58 ` Steven Rostedt [this message]
2017-03-15 16:08 ` Jiri Slaby
-- strict thread matches above, loose matches on Subject: below --
2015-10-06 12:40 Jiri Slaby
2015-10-20 19:02 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170315115812.07ab384d@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®