From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753656AbdCOOJe (ORCPT ); Wed, 15 Mar 2017 10:09:34 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:49290 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751732AbdCOOIX (ORCPT ); Wed, 15 Mar 2017 10:08:23 -0400 Date: Wed, 15 Mar 2017 15:08:11 +0100 From: Andrew Lunn To: Roger Quadros Cc: f.fainelli@gmail.com, davem@davemloft.net, kyle.roeschley@ni.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] net: phy: Don't miss phy_suspend() on PHY_HALTED for PHYs with interrupts Message-ID: <20170315140811.GD21021@lunn.ch> References: <1489585887-8683-1-git-send-email-rogerq@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1489585887-8683-1-git-send-email-rogerq@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 15, 2017 at 03:51:27PM +0200, Roger Quadros wrote: > Since commit 3c293f4e08b5 ("net: phy: Trigger state machine on state change and not polling.") > phy_suspend() doesn't get called as part of phy_stop() for PHYs using > interrupts because the phy state machine is never triggered after a phy_stop(). > > Explicitly trigger the PHY state machine so that it can > see the new PHY state (HALTED) and suspend the PHY. > > Signed-off-by: Roger Quadros Hi Roger This seems sensible. It mirrors what phy_start() does. Reviewed-by: Andrew Lunn It does however lead to a follow up question. Are there other places phydev->state is changed and it is missing a phy_trigger_machine()? Andrew