mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: linux-kbuild@vger.kernel.org
Cc: Michal Marek <mmarek@suse.com>,
	linux-kernel@vger.kernel.org,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>
Subject: Re: kbuild/mkspec: Fix architectures where KBUILD_IMAGE isn't a full path
Date: Wed, 15 Mar 2017 10:51:18 -0400	[thread overview]
Message-ID: <20170315145118.GA30463@bill-the-cat> (raw)
In-Reply-To: <1489276762-22280-1-git-send-email-trini@konsulko.com>

[-- Attachment #1: Type: text/plain, Size: 1393 bytes --]

On Sat, Mar 11, 2017 at 11:59:22PM +0000, Tom Rini wrote:

> On some architectures, such as arm64, KBUILD_IMAGE is not a full path
> but instead just the build target.  The builddeb script handles this
> case correctly today and will try arch/$ARCH/boot/$KBUILD_IMAGE so we
> can just borrow that logic and adapt it slightly for spec file syntax.
> 
> Cc: Michal Marek <mmarek@suse.com>
> Cc: linux-kbuild@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> It is currently a mixed-bag on if architectures will use a build target
> (arm, arm64, arc are certainly by inspection and a few others 'may') or
> a full path (x86, blackfin, s390).  Given that builddeb gets this case
> correct, I think changing mkspec is the right way to go here.

I found https://patchwork.kernel.org/patch/9442211/ today and I see that
it was brought up again just before I sent my patch.  I just want to
point out that 9442211 doesn't address arm, arc, and sh and they will
still not have a functional rpm build target.  This is at least probably
important for arm.  Of course all of those could also be addressed with
a patch similar to 9442211, and my main concern is making sure
everything gets fixed one way or another.  Thanks!

-- 
Tom

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2017-03-15 14:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-11 23:59 [PATCH] " Tom Rini
2017-03-15 14:51 ` Tom Rini [this message]
2017-03-15 15:03   ` Michal Marek
2017-03-15 15:37     ` Tom Rini
2017-03-20 10:13       ` Will Deacon
2017-03-20 17:00         ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170315145118.GA30463@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=catalin.marinas@arm.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome