From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754259AbdCOXN3 (ORCPT ); Wed, 15 Mar 2017 19:13:29 -0400 Received: from mail.kernel.org ([198.145.29.136]:45326 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752035AbdCOXMn (ORCPT ); Wed, 15 Mar 2017 19:12:43 -0400 Date: Wed, 15 Mar 2017 19:11:24 -0400 From: Steven Rostedt To: Josh Poimboeuf Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Thomas Gleixner , Peter Zijlstra , Masami Hiramatsu , "H. Peter Anvin" , Andy Lutomirski , Linus Torvalds Subject: Re: [RFC][PATCH 4/5] ftrace/x86_32: Clean up ftrace_regs_caller Message-ID: <20170315191124.0e175b24@gandalf.local.home> In-Reply-To: <20170315211343.q62tvl7rd6ourdlv@treble> References: <20170315195527.703131481@goodmis.org> <20170315200255.564342348@goodmis.org> <20170315211343.q62tvl7rd6ourdlv@treble> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Mar 2017 16:13:43 -0500 Josh Poimboeuf wrote: > On Wed, Mar 15, 2017 at 03:55:31PM -0400, Steven Rostedt wrote: > > From: "Steven Rostedt (VMware)" > > > > When ftrace_regs_caller was created, it was designed to preserve flags as > > much as possible as it needed to act just like a breakpoint triggered on the > > same location. But the design is over complicated as it treated all > > operations as modifying flags. But push, mov and lea do not modify flags. > > This means the code can become more simplified by allowing flags to be > > stored further down. > > > > Making ftrace_regs_caller simpler will also be useful in implementing fentry > > logic. > > > > Signed-off-by: Steven Rostedt (VMware) > > --- > > arch/x86/kernel/ftrace_32.S | 45 +++++++++++++++++++++++++-------------------- > > 1 file changed, 25 insertions(+), 20 deletions(-) > > > > diff --git a/arch/x86/kernel/ftrace_32.S b/arch/x86/kernel/ftrace_32.S > > index 73d61a62649d..8ca33d9806ac 100644 > > --- a/arch/x86/kernel/ftrace_32.S > > +++ b/arch/x86/kernel/ftrace_32.S > > @@ -55,23 +55,30 @@ WEAK(ftrace_stub) > > END(ftrace_caller) > > > > ENTRY(ftrace_regs_caller) > > - pushf /* push flags before compare (in cs location) */ > > - > > /* > > * i386 does not save SS and ESP when coming from kernel. > > * Instead, to get sp, ®s->sp is used (see ptrace.h). > > * Unfortunately, that means eflags must be at the same location > > * as the current return ip is. We move the return ip into the > > - * ip location, and move flags into the return ip location. > > - */ > > - pushl 4(%esp) /* save return ip into ip slot */ > > + * regs->ip location, and move flags into the return ip location. > > + */ > > + pushl $__KERNEL_CS > > + pushl 4(%esp) /* Save the return ip */ > > + > > + /* temporarily save flags in the orig_ax location */ > > + pushf > > > > - pushl $0 /* Load 0 into orig_ax */ > > pushl %gs > > pushl %fs > > pushl %es > > pushl %ds > > pushl %eax > > + > > + /* move flags into the location of where the return ip was */ > > + movl 5*4(%esp), %eax > > + movl $0, (%esp) /* Load 0 into orig_ax */ > > This writes a 0 into regs->ax instead of regs->orig_ax. > Ouch, I'm surprised this didn't crash my box. Thanks for catching it. -- Steve