mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: mshan <educha997@gmail.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	mohsinshan1k@gmail.com
Subject: Re: [PATCH] Staging: goldfish: use __func__ instead of embedded function names
Date: Thu, 16 Mar 2017 10:54:42 +0900	[thread overview]
Message-ID: <20170316015442.GB27735@kroah.com> (raw)
In-Reply-To: <1489568992-2495-1-git-send-email-mohsinshan1k@gmail.com>

On Wed, Mar 15, 2017 at 02:09:52AM -0700, mshan wrote:
> Embedded function names are less appropriate to use when
> refactoring, can cause function renaming.  Prefer the use
> of "%s", __func__ to embedded function names
> 
> Signed-off-by: Mohsin Shan <educha997@gmail.com>

Your name in the From: line in your email does not match this name :(

Please fix and resend.

thanks,

greg k-h

  reply	other threads:[~2017-03-16  2:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-15  9:09 mshan
2017-03-16  1:54 ` Greg KH [this message]
2017-03-16  3:51 Mohsin Shan
2017-03-16 11:10 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170316015442.GB27735@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=educha997@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mohsinshan1k@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®