From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750987AbdCPErm (ORCPT ); Thu, 16 Mar 2017 00:47:42 -0400 Received: from mail-pf0-f182.google.com ([209.85.192.182]:34515 "EHLO mail-pf0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750858AbdCPErk (ORCPT ); Thu, 16 Mar 2017 00:47:40 -0400 Date: Thu, 16 Mar 2017 13:47:04 +0900 From: Sergey Senozhatsky To: Andi Kleen Cc: Dmitry Vyukov , Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , Andrew Morton , linux-mm@kvack.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: [mmotm] "x86/atomic: move __arch_atomic_add_unless out of line" build error Message-ID: <20170316044704.GA729@jagdpanzerIV.localdomain> Reply-To: 20170315021431.13107-3-andi@firstfloor.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, commit 4f86a82ff7df ("x86/atomic: move __arch_atomic_add_unless out of line") moved __arch_atomic_add_unless() out atomic.h and new KASAN atomic instrumentation [1] can't see it anymore In file included from ./arch/x86/include/asm/atomic.h:257:0, from ./include/linux/atomic.h:4, from ./include/asm-generic/qspinlock_types.h:28, from ./arch/x86/include/asm/spinlock_types.h:26, from ./include/linux/spinlock_types.h:13, from kernel/bounds.c:13: ./include/asm-generic/atomic-instrumented.h: In function ‘__atomic_add_unless’: ./include/asm-generic/atomic-instrumented.h:70:9: error: implicit declaration of function ‘__arch_atomic_add_unless’ [-Werror=implicit-function-declaration] return __arch_atomic_add_unless(v, a, u); ^~~~~~~~~~~~~~~~~~~~~~~~ so we need a declaration of __arch_atomic_add_unless() in arch/x86/include/asm/atomic.h [1] lkml.kernel.org/r/7e450175a324bf93c602909c711bc34715d8e8f2.1489519233.git.dvyukov@google.com -ss