From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752031AbdCPNCV (ORCPT <rfc822;w@1wt.eu>);
        Thu, 16 Mar 2017 09:02:21 -0400
Received: from mail.kernel.org ([198.145.29.136]:49410 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751357AbdCPNCT (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 16 Mar 2017 09:02:19 -0400
Date: Thu, 16 Mar 2017 09:02:10 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Andy Lutomirski <luto@amacapital.net>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [RFC][PATCH 5/5] ftrace/x86-32: Add -mfentry support to x86_32
 with DYNAMIC_FTRACE set
Message-ID: <20170316090210.633b2818@gandalf.local.home>
In-Reply-To: <20170316182412.965a091f2721062b21556da7@kernel.org>
References: <20170315195527.703131481@goodmis.org>
        <20170315200255.828608428@goodmis.org>
        <20170316182412.965a091f2721062b21556da7@kernel.org>
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 16 Mar 2017 18:24:12 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:

> > +/* mcount uses a frame pointer even if CONFIG_FRAME_POINTER is not set */
> > +#if !defined(CC_USING_FENTRY) || defined(CONFIG_FRAME_POINTER)
> > +# define USING_FRAME_POINTER
> > +#endif
> > +
> > +#ifdef USING_FRAME_POINTER
> > +# ifdef CC_USING_FENTRY
> > +#  define MCOUNT_FRAME_SIZE		(4*4)	/* bp,ip and parent's  */
> > +# else
> > +#  define MCOUNT_FRAME_SIZE		4	/* just the bp         */
> > +# endif
> > +# define MCOUNT_FRAME			1	/* using frame = true  */
> > +#else
> > +# define MCOUNT_FRAME_SIZE		0	/* no stack frame      */
> > +# define MCOUNT_FRAME			0	/* using frame = false */
> > +#endif  
> 
> It seems that there is no use of MCOUNT_FRAME_SIZE below. Do we really need it?

Hmm, one of the previous versions of my patch required it. I think I
was able to tinker with the code to remove all the use cases of it. But
I never removed the definition. Thanks, I'll fix this too.

-- Steve