From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751536AbdCPKdJ (ORCPT ); Thu, 16 Mar 2017 06:33:09 -0400 Received: from mx2.suse.de ([195.135.220.15]:43177 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751342AbdCPKdI (ORCPT ); Thu, 16 Mar 2017 06:33:08 -0400 Date: Thu, 16 Mar 2017 11:33:06 +0100 From: Michal Hocko To: Joe Perches Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 02/15] mm: page_alloc: align arguments to parenthesis Message-ID: <20170316103306.GI30501@dhcp22.suse.cz> References: <317ef9c31dba4c02905ad0222761b4337f081411.1489628477.git.joe@perches.com> <20170316080240.GB30501@dhcp22.suse.cz> <1489660167.13953.1.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1489660167.13953.1.camel@perches.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 16-03-17 03:29:27, Joe Perches wrote: > On Thu, 2017-03-16 at 09:02 +0100, Michal Hocko wrote: > > On Wed 15-03-17 18:59:59, Joe Perches wrote: > > > whitespace changes only - git diff -w shows no difference > > > > what is the point of this whitespace noise? Does it help readability? > > Yes. Consistency helps. Causing context conflicts doesn't though. > > To be honest I do not think so. > > Opinions always vary. Yes the vary and I do not like this. If you find somebody to ack then I will not complain but I would appreciate if a more useful stuff was done in mm/page_alloc.c -- Michal Hocko SUSE Labs