From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752062AbdCPK6d (ORCPT ); Thu, 16 Mar 2017 06:58:33 -0400 Received: from mx2.suse.de ([195.135.220.15]:46130 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751279AbdCPK6b (ORCPT ); Thu, 16 Mar 2017 06:58:31 -0400 Date: Thu, 16 Mar 2017 11:58:28 +0100 From: Michal Hocko To: Joe Perches Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 3/3] mm: page_alloc: Break up a long single-line printk Message-ID: <20170316105828.GD30508@dhcp22.suse.cz> References: <3ceb85654e0cfe5168cc36f96a6e09822cf7139e.1489628459.git.joe@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3ceb85654e0cfe5168cc36f96a6e09822cf7139e.1489628459.git.joe@perches.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 15-03-17 18:43:15, Joe Perches wrote: > Blocked multiple line output is easier to read than an > extremely long single line. I am not really sure this is an improvemnt. If anything add an output before and after to the changelog. -- Michal Hocko SUSE Labs