From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752075AbdCPLL3 (ORCPT ); Thu, 16 Mar 2017 07:11:29 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:35137 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751973AbdCPLL0 (ORCPT ); Thu, 16 Mar 2017 07:11:26 -0400 Date: Thu, 16 Mar 2017 14:10:35 +0300 From: Dan Carpenter To: Mohsin Shan Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, educha997@gmail.com Subject: Re: [PATCH] Staging: goldfish: use __func__ instead of embedded function names Message-ID: <20170316111035.GB4124@mwanda> References: <1489636302-12321-1-git-send-email-mohsinshan1k@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1489636302-12321-1-git-send-email-mohsinshan1k@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org You should have put a v3 in the subject and a changelog under the --- cut off but otherwise it looks good. Thanks! regards, dan carpenter