From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Lee Jones <lee.jones@linaro.org>, linux-kernel@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v1] mfd: core: Preserve PLATFORM_DEVID_NONE
Date: Thu, 16 Mar 2017 16:19:59 +0200 [thread overview]
Message-ID: <20170316141959.16018-1-andriy.shevchenko@linux.intel.com> (raw)
There is a potential flaw if cell has id > 0 and is going to be
registered with PLATFORM_DEVID_NONE.
Ignore if PLATFORM_DEVID_NONE is supplied.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/mfd/mfd-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
index c57e407020f1..c9583f895058 100644
--- a/drivers/mfd/mfd-core.c
+++ b/drivers/mfd/mfd-core.c
@@ -149,7 +149,7 @@ static int mfd_add_device(struct device *parent, int id,
int platform_id;
int r;
- if (id == PLATFORM_DEVID_AUTO)
+ if (id < 0)
platform_id = id;
else
platform_id = id + cell->id;
--
2.11.0
next reply other threads:[~2017-03-16 14:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 14:19 Andy Shevchenko [this message]
2017-03-23 11:21 ` Lee Jones
2017-03-23 13:09 ` Andy Shevchenko
2017-03-24 11:35 ` Lee Jones
2017-03-26 12:53 ` Andy Shevchenko
2017-03-27 12:41 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170316141959.16018-1-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome