From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753068AbdCPWxu (ORCPT <rfc822;w@1wt.eu>);
        Thu, 16 Mar 2017 18:53:50 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:44446 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752558AbdCPWxt (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 16 Mar 2017 18:53:49 -0400
Date: Thu, 16 Mar 2017 15:53:47 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Joe Perches <joe@perches.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/3] mm: page_alloc: Reduce object size by neatening
 printks
Message-Id: <20170316155347.966f5597082692df04494c4d@linux-foundation.org>
In-Reply-To: <1489689476.13953.3.camel@perches.com>
References: <cover.1489628459.git.joe@perches.com>
        <880b3172b67d806082284d80945e4a231a5574bb.1489628459.git.joe@perches.com>
        <20170316113056.GG464@jagdpanzerIV.localdomain>
        <1489689476.13953.3.camel@perches.com>
X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 16 Mar 2017 11:37:56 -0700 Joe Perches <joe@perches.com> wrote:

> > this can make it harder to read, in _the worst case_. one printk()
> > guaranteed that we would see a single line in the serial log/etc.
> > the sort of a problem with multiple printks is that printks coming
> > from other CPUs will split that "previously single" line.
> 
> Not true.  Note the multiple \n uses in the original code.

hm?  Won't printk("a\na") atomically emit all three chars into the log
buffer?