From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755180AbdCPQOz (ORCPT ); Thu, 16 Mar 2017 12:14:55 -0400 Received: from merlin.infradead.org ([205.233.59.134]:34878 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755125AbdCPQOr (ORCPT ); Thu, 16 Mar 2017 12:14:47 -0400 Date: Thu, 16 Mar 2017 17:14:29 +0100 From: Peter Zijlstra To: Tejun Heo Cc: Oleg Nesterov , Linus Torvalds , Andrew Morton , Thomas Gleixner , Chris Mason , linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 1/2] kthread: add barriers to set_kthread_struct() and to_kthread() Message-ID: <20170316161429.xaut44wpycty7di4@hirez.programming.kicks-ass.net> References: <20170315231827.GA13656@htj.duckdns.org> <20170316145436.GA24478@redhat.com> <20170316153301.GA15810@htj.duckdns.org> <20170316153843.GB15810@htj.duckdns.org> <20170316155534.zbtmy5v7gh6pbuhl@hirez.programming.kicks-ass.net> <20170316160944.GE15810@htj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170316160944.GE15810@htj.duckdns.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 16, 2017 at 12:09:44PM -0400, Tejun Heo wrote: > On Thu, Mar 16, 2017 at 04:55:34PM +0100, Peter Zijlstra wrote: > > > Oops, as for adding lockless_assign_pointer(), wouldn't smp_wmb() be a > > > better match for smp_read_barrier_depends()? ISTR acquire/release > > > pairs being more expensive on some archs. > > > > 88c1863066cc ("rcu: Define rcu_assign_pointer() in terms of smp_store_release()") > > Hmmm, nice, can we always prefer store_release over wmb from now on? I would advocate using whichever barrier is most natural for the occasion. Only if there really is a very very compelling performance argument should we look further.