From: Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Andy Shevchenko <andy@infradead.org>,
Zha Qipeng <qipeng.zha@intel.com>,
"dvhart@infradead.org" <dvhart@infradead.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/1] platform/x86: intel_pmc_ipc: fix io mem mapping size
Date: Thu, 16 Mar 2017 23:43:56 +0530 [thread overview]
Message-ID: <20170316181356.GA19029@rajaneesh-OptiPlex-9010> (raw)
In-Reply-To: <CAHp75VdTJLUG_SJYm7pk5Aoqs=gV0QG2yJGe4y9pP98yvHcKLw@mail.gmail.com>
On Thu, Mar 16, 2017 at 06:05:39PM +0200, Andy Shevchenko wrote:
> On Thu, Mar 16, 2017 at 4:52 PM, Rajneesh Bhardwaj
> <rajneesh.bhardwaj@intel.com> wrote:
> > On Wed, Mar 15, 2017 at 08:32:53PM -0700, Kuppuswamy Sathyanarayanan wrote:
> >> Mapping entire GCR mem region in this driver creates
> >> mem region request conflict in sub devices that depend
> >> on PMC. This creates driver probe failure in devices like
> >> iTC0_wdt and telemetry device.
>
> > iTCO_WDT driver needs to check the BIT4 (NO_REBOOT) of PMC_CFG register
> > (Offset: 0x1008) and this falls in GCR space.
>
> Are we talking about ACPI-enabled platform?
>
IIUC, you are referring to WDT enumerated by ACPI tables (WDAT, WDRT etc) ?
On APL/BXT i think we pass the resource mapping to iTCO_WDT driver since
acpi_has_watchdog provides the required protection. For non ACPI-enabled
platforms we have this issue since iTCO_WDT driver anyway tries resource
mapping when the iTCO_version >=2.
Can someone please explain whether we can have iTCO_version >=2 for Intel
Core SoCs as well or its for Atom only?
> --
> With Best Regards,
> Andy Shevchenko
--
Best Regards,
Rajneesh
next prev parent reply other threads:[~2017-03-16 18:15 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 3:32 Kuppuswamy Sathyanarayanan
2017-03-16 14:52 ` Rajneesh Bhardwaj
2017-03-16 16:05 ` Andy Shevchenko
2017-03-16 18:13 ` Rajneesh Bhardwaj [this message]
2017-03-16 20:12 ` Andy Shevchenko
2017-03-16 21:15 ` sathyanarayanan kuppuswamy
2017-03-16 18:50 ` sathyanarayanan kuppuswamy
2017-03-16 19:20 ` Rajneesh Bhardwaj
2017-03-16 21:05 ` sathyanarayanan kuppuswamy
2017-03-17 0:41 ` [PATCH v2 1/4] platform/x86: intel_pmc_ipc: fix gcr offset Kuppuswamy Sathyanarayanan
2017-03-17 0:41 ` [PATCH v2 2/4] platform/x86: intel_pmc_ipc: Add pmc gcr read/write api's Kuppuswamy Sathyanarayanan
2017-03-17 11:26 ` Rajneesh Bhardwaj
2017-03-17 17:11 ` sathyanarayanan kuppuswamy
2017-03-17 0:41 ` [PATCH v2 3/4] watchdog: iTCO_wdt: Fix PMC GCR memory mapping failure Kuppuswamy Sathyanarayanan
2017-03-17 11:43 ` Rajneesh Bhardwaj
2017-03-17 13:40 ` Guenter Roeck
2017-03-17 14:05 ` Rajneesh Bhardwaj
2017-03-17 14:25 ` Andy Shevchenko
2017-03-17 17:37 ` sathyanarayanan kuppuswamy
2017-03-17 18:38 ` Andy Shevchenko
2017-03-17 18:50 ` sathyanarayanan kuppuswamy
2017-03-17 17:24 ` sathyanarayanan kuppuswamy
2017-03-17 17:50 ` Guenter Roeck
2017-03-17 18:39 ` sathyanarayanan kuppuswamy
2017-03-17 17:15 ` sathyanarayanan kuppuswamy
2017-03-20 2:52 ` kbuild test robot
2017-03-17 0:41 ` [PATCH v2 4/4] platform/x86: intel_pmc_ipc: remove iTCO GCR mem resource Kuppuswamy Sathyanarayanan
2017-03-17 11:47 ` Rajneesh Bhardwaj
2017-03-17 11:13 ` [PATCH v2 1/4] platform/x86: intel_pmc_ipc: fix gcr offset Rajneesh Bhardwaj
2017-03-17 17:06 ` sathyanarayanan kuppuswamy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170316181356.GA19029@rajaneesh-OptiPlex-9010 \
--to=rajneesh.bhardwaj@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=qipeng.zha@intel.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®