mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
	anirudh@xilinx.com, linux-ide@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Anurag Kumar Vulisha <anuragku@xilinx.com>
Subject: Re: [RFC PATCH] drivers: ata: Add [save|restore]_initial_config override functions
Date: Thu, 16 Mar 2017 17:30:32 -0400	[thread overview]
Message-ID: <20170316213032.GE1480@htj.duckdns.org> (raw)
In-Reply-To: <1489492761-815-1-git-send-email-anuragku@xilinx.com>

On Tue, Mar 14, 2017 at 05:29:21PM +0530, Anurag Kumar Vulisha wrote:
> @@ -613,7 +613,10 @@ static void ahci_pci_save_initial_config(struct pci_dev *pdev,
>  			  "Disabling your PATA port. Use the boot option 'ahci.marvell_enable=0' to avoid this.\n");
>  	}
>  
> -	ahci_save_initial_config(&pdev->dev, hpriv);
> +	if (hpriv->save_initial_config == NULL)
> +		ahci_save_initial_config(dev, hpriv);
> +	else
> +		hpriv->save_initial_config(dev, hpriv);

Can you just initialize hpriv->save_initial_config to
ahci_save_initial_config and let the init function override it as
necessary?

Thanks.

-- 
tejun

      reply	other threads:[~2017-03-16 21:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-14 11:59 Anurag Kumar Vulisha
2017-03-16 21:30 ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170316213032.GE1480@htj.duckdns.org \
    --to=tj@kernel.org \
    --cc=anirudh@xilinx.com \
    --cc=anurag.kumar.vulisha@xilinx.com \
    --cc=anuragku@xilinx.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®