From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751101AbdCQGLy (ORCPT ); Fri, 17 Mar 2017 02:11:54 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:45976 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750774AbdCQGLx (ORCPT ); Fri, 17 Mar 2017 02:11:53 -0400 Date: Fri, 17 Mar 2017 15:11:37 +0900 From: Greg Kroah-Hartman To: Logan Gunthorpe Cc: kernel test robot , LKP , linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, wfg@linux.intel.com Subject: Re: [rtc] 4cd8adb100: WARNING: CPU: 0 PID: 1 at lib/kobject.c:690 kobject_put Message-ID: <20170317061137.GA21612@kroah.com> References: <58cb6cce.GwD02K343UlZPrBA%fengguang.wu@intel.com> <72ddb00d-3eda-1a16-9c3b-10055dd4e730@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <72ddb00d-3eda-1a16-9c3b-10055dd4e730@deltatee.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 16, 2017 at 11:23:26PM -0600, Logan Gunthorpe wrote: > Hey, > > I think I see the issue here: in a couple of error conditions, the RTC > code will not initialize and ask for the cdev. However, my change will > always call cdev_add and cdev_del even though the rtc code did not call > cdev_init. I'll have to add a guard around dev->devt in the new > cdev_device functions. I'll prepare another patch tomorrow. > > I also noticed that I neglected to remove the prototypes for the two RTC > function I removed. I'll fix that too. Ok, I'm just going to drop this series from my tree so that other patches in it can get pushed out to linux-next. Please resend the full series after you have fixed it up, and I'll be glad to queue it up again. thanks, greg k-h