From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751062AbdCQLrl (ORCPT <rfc822;w@1wt.eu>);
        Fri, 17 Mar 2017 07:47:41 -0400
Received: from mx2.suse.de ([195.135.220.15]:44377 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750898AbdCQLrk (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 17 Mar 2017 07:47:40 -0400
Date: Fri, 17 Mar 2017 12:47:33 +0100
From: Michal Hocko <mhocko@kernel.org>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Andi Kleen <ak@linux.intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Shaohua Li <shli@kernel.org>, Rik van Riel <riel@redhat.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Tim Chen <tim.c.chen@linux.intel.com>,
        Mel Gorman <mgorman@techsingularity.net>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        =?iso-8859-1?B?Suly9G1l?= Glisse <jglisse@redhat.com>,
        Aaron Lu <aaron.lu@intel.com>, Hugh Dickins <hughd@google.com>,
        Minchan Kim <minchan@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Vegard Nossum <vegard.nossum@oracle.com>, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org
Subject: Re: [PATCH 4/5] mm, swap: Try kzalloc before vzalloc
Message-ID: <20170317114732.GF26298@dhcp22.suse.cz>
References: <20170317064635.12792-1-ying.huang@intel.com>
 <20170317064635.12792-4-ying.huang@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170317064635.12792-4-ying.huang@intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri 17-03-17 14:46:22, Huang, Ying wrote:
> +void *swap_kvzalloc(size_t size)
> +{
> +	void *p;
> +
> +	p = kzalloc(size, GFP_KERNEL | __GFP_NOWARN);
> +	if (!p)
> +		p = vzalloc(size);
> +
> +	return p;
> +}

please do not invent your own kvmalloc implementation when we already
have on in mmotm tree.
-- 
Michal Hocko
SUSE Labs