From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751102AbdCQNIb (ORCPT ); Fri, 17 Mar 2017 09:08:31 -0400 Received: from mail.kernel.org ([198.145.29.136]:38994 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750999AbdCQNI3 (ORCPT ); Fri, 17 Mar 2017 09:08:29 -0400 Date: Fri, 17 Mar 2017 20:40:20 +0800 From: Jaegeuk Kim To: Chao Yu Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: don't allow atomic writes for not regular files Message-ID: <20170317124020.GA34674@jaegeuk.local> References: <20170317020906.28165-1-jaegeuk@kernel.org> <20170317020906.28165-2-jaegeuk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/17, Chao Yu wrote: > On 2017/3/17 10:09, Jaegeuk Kim wrote: > > The atomic writes only supports regular files for database. > > > > Signed-off-by: Jaegeuk Kim > > --- > > fs/f2fs/file.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > > index da6d33d1bb34..d486e02b43c2 100644 > > --- a/fs/f2fs/file.c > > +++ b/fs/f2fs/file.c > > @@ -1522,6 +1522,9 @@ static int f2fs_ioc_start_atomic_write(struct file *filp) > > if (f2fs_is_atomic_file(inode)) > > goto out; > > > > + if (!S_ISREG(inode->i_mode)) > > + return -EINVAL; > > goto out; Oh, I just move it to the beginning of the function. Thanks, > > Thanks, > > > + > > ret = f2fs_convert_inline_inode(inode); > > if (ret) > > goto out; > >