From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751314AbdCQW2E (ORCPT ); Fri, 17 Mar 2017 18:28:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51838 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751258AbdCQW2C (ORCPT ); Fri, 17 Mar 2017 18:28:02 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B62897F3EC Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=alex.williamson@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com B62897F3EC Date: Fri, 17 Mar 2017 16:27:55 -0600 From: Alex Williamson To: Manish Jaggi Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, "Daney, David" , bhelgaas@google.com Subject: Re: [PATCH] pci: quirk cavium: Add device ID range check Message-ID: <20170317162755.60423972@t450s.home> In-Reply-To: <43ff1f3f-b098-f25d-b9dc-9e8ef2278110@caviumnetworks.com> References: <43ff1f3f-b098-f25d-b9dc-9e8ef2278110@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 17 Mar 2017 22:27:57 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 17 Mar 2017 12:46:29 +0530 Manish Jaggi wrote: > ACS quirk applies to devices with ID in the range a000-a0XX. > The patch adds a check.This matches on-chip pci devices for > CN81xx/CN83xx/CN88xx > > This patch adds check to > b404bcfbf0 : PCI: Add ACS quirk for all Cavium devices > > Signed-off-by: Manish Jaggi > Acked-by: David Daney Fixes: b404bcfbf035 ("PCI: Add ACS quirk for all Cavium devices") Reported-by: Alex Williamson Acked-by: Alex Williamson Thanks > --- > drivers/pci/quirks.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > index f754453..178242d 100644 > --- a/drivers/pci/quirks.c > +++ b/drivers/pci/quirks.c > @@ -4094,6 +4094,9 @@ static int pci_quirk_cavium_acs(struct pci_dev *dev, u16 acs_flags) > acs_flags &= ~(PCI_ACS_SV | PCI_ACS_TB | PCI_ACS_RR | > PCI_ACS_CR | PCI_ACS_UF | PCI_ACS_DT); > > + if (!((dev->device >= 0xa000) && (dev->device <= 0xa0ff))) > + return -ENOTTY; > + > return acs_flags ? 0 : 1; > } >