From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Andrew Duggan <aduggan@synaptics.com>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: [PATCH v3 9/9] [NEEDS F21] Input: synaptics - switch forcepad devices over to SMbus access
Date: Sun, 19 Mar 2017 17:22:31 -0700 [thread overview]
Message-ID: <20170320002231.31152-10-dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <20170320002231.31152-1-dmitry.torokhov@gmail.com>
Synaptics "forcedpad" devices use address 0x20 instead of 0x2c.
Unfortunately the fact that the device is a forcepad is not exported
through PS/2 interface, so we need a bit of DMI magic to switch over to the
correct address.
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/mouse/synaptics.c | 23 ++++++++++++++---------
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index 20c329bba46a..86ed45bda7bb 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -171,6 +171,13 @@ static const char * const smbus_pnp_ids[] = {
NULL
};
+/* This list has been kindly provided by Synaptics. */
+static const char * const forcepad_pnp_ids[] = {
+ "SYN300D",
+ "SYN3014",
+ NULL
+};
+
/*
* Send a command to the synpatics touchpad by special commands
*/
@@ -493,13 +500,6 @@ static const struct min_max_quirk min_max_pnpid_table[] = {
{ }
};
-/* This list has been kindly provided by Synaptics. */
-static const char * const forcepad_pnp_ids[] = {
- "SYN300D",
- "SYN3014",
- NULL
-};
-
/*****************************************************************************
* Synaptics communications functions
****************************************************************************/
@@ -1723,11 +1723,14 @@ static int synaptics_create_intertouch(struct psmouse *psmouse,
!!SYN_CAP_EXT_BUTTONS_STICK(info->ext_cap_10),
},
};
- const struct i2c_board_info intertouch_board = {
+ struct i2c_board_info intertouch_board = {
I2C_BOARD_INFO("rmi4_smbus", 0x2c),
.flags = I2C_CLIENT_HOST_NOTIFY,
};
+ if (psmouse_matches_pnp_id(psmouse, forcepad_pnp_ids))
+ intertouch_board.addr = 0x20;
+
return psmouse_smbus_init(psmouse, &intertouch_board,
&pdata, sizeof(pdata),
leave_breadcrumbs);
@@ -1748,8 +1751,10 @@ static int synaptics_setup_intertouch(struct psmouse *psmouse,
if (synaptics_intertouch == SYNAPTICS_INTERTOUCH_NOT_SET) {
if (!psmouse_matches_pnp_id(psmouse, topbuttonpad_pnp_ids) &&
- !psmouse_matches_pnp_id(psmouse, smbus_pnp_ids))
+ !psmouse_matches_pnp_id(psmouse, smbus_pnp_ids) &&
+ !psmouse_matches_pnp_id(psmouse, forcepad_pnp_ids)) {
return -ENXIO;
+ }
}
psmouse_info(psmouse, "Trying to set up SMBus access\n");
--
2.12.0.367.g23dc2f6d3c-goog
next prev parent reply other threads:[~2017-03-20 0:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 0:22 [PATCH v3 0/9] PS/2 and SMBus companions Dmitry Torokhov
2017-03-20 0:22 ` [PATCH v3 1/9] i2c: export i2c_client_type structure Dmitry Torokhov
2017-03-20 0:22 ` [PATCH v3 2/9] Input: serio - add fast reconnect option Dmitry Torokhov
2017-03-20 0:22 ` [PATCH v3 3/9] Input: psmouse - implement " Dmitry Torokhov
2017-03-20 0:22 ` [PATCH v3 4/9] Input: psmouse - store pointer to current protocol Dmitry Torokhov
2017-03-20 0:22 ` [PATCH v3 5/9] Input: psmouse - introduce notion of SMBus companions Dmitry Torokhov
2017-03-20 0:22 ` [PATCH v3 6/9] Input: psmouse - add support for " Dmitry Torokhov
2017-03-20 0:22 ` [PATCH v3 7/9] Input: synaptics - split device info into a separate structure Dmitry Torokhov
2017-03-20 0:22 ` [PATCH v3 8/9] Input: synaptics - add support for Intertouch devices Dmitry Torokhov
2017-03-20 0:22 ` Dmitry Torokhov [this message]
2017-03-21 15:17 ` [PATCH v3 0/9] PS/2 and SMBus companions Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170320002231.31152-10-dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=aduggan@synaptics.com \
--cc=benjamin.tissoires@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®