From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752891AbdCTGzT (ORCPT ); Mon, 20 Mar 2017 02:55:19 -0400 Received: from mail.kernel.org ([198.145.29.136]:45056 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750989AbdCTGzS (ORCPT ); Mon, 20 Mar 2017 02:55:18 -0400 Date: Mon, 20 Mar 2017 07:54:53 +0100 From: Sebastian Reichel To: Milo Kim Cc: Lee Jones , Daniel Thompson , Jingoo Han , linux-kernel@vger.kernel.org, Rob Herring , Tony Lindgren Subject: Re: [PATCH] backlight: Add TI LMU backlight driver Message-ID: <20170320065453.lzof5jxiz2mt2e7c@earth> References: <20170320022104.6448-1-milo.kim@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wzbml2k4f4yk4hns" Content-Disposition: inline In-Reply-To: <20170320022104.6448-1-milo.kim@ti.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --wzbml2k4f4yk4hns Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, Mar 20, 2017 at 11:21:04AM +0900, Milo Kim wrote: > This is consolidated driver which supports backlight devices below. > LM3532, LM3631, LM3632, LM3633, LM3695 and LM3697. >=20 > Structure > --------- > It consists of two parts - core and data. >=20 > Core part supports features below. > - Backlight subsystem control > - Channel configuration from DT properties > - Light dimming effect control: ramp up and down. > - LMU fault monitor notifier handling > - PWM brightness control >=20 > Data part describes device specific data. > - Register value configuration for each LMU device > : initialization, channel configuration, control mode, enable and > brightness. > - PWM action configuration > - Light dimming effect table > - Option for LMU fault monitor support >=20 > Macros for register data > ------------------------ > All LMU devices have 8-bit based registers. LMU_BL_REG() creates 24-bit > register value in data part. It consists of address, mask and value. > On the other hand, register value should be parsed when the driver > reads/writes data from/to I2C registers. Driver uses LMU_BL_GET_ADDR(), > LMU_BL_GET_MASK() and LMU_BL_GET_VAL() for this purpose. >=20 > Data structure > -------------- > ti_lmu_bl: Backlight output channel data > ti_lmu_bl_chip: Backlight device data. One device can have multiple > backlight channel data. > ti_lmu_bl_reg: Backlight device register data > ti_lmu_bl_cfg: Backlight configuration data for each LMU device >=20 > Cc: Rob Herring > Cc: Sebastian Reichel > Cc: Tony Lindgren > Signed-off-by: Milo Kim Works on Droid 4: Tested-by: Sebastian Reichel -- Sebastian --wzbml2k4f4yk4hns Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAljPfLoACgkQ2O7X88g7 +prT5w//dl8h5o598wnskY66mDRZWuovZs7gy30Spn2V7m5gRJRcfNE7+nPe4GY/ O4WyZdnNAbkPh9YiAcYrZxQD7YgD1EhX3GIHYfXczgP+O6aoZ1UpZaBoQX9/8qaK gJc+UxHS0Kms7rwK6EwQePBT+f5GUNDUyisuT6jFlvzNEI2XMa5KvnGKBxIlmhNK jz80Jh/3Z1HXXdKTDWWsCOynNv/oNpa5vi4QXM0fLqWHA12QOC3WCfQQkncBxRab X37RfCeDqv7iYiHiGgo65YR+okERdwGjTpqdtzenjdisM/BTY0D2mabXJEqIzWwh kWGH4czCt3z3ZD2OoMZancb2iTwSIQprMRfQQW0wP2jNMnepozcGRDeAq7VNkO5e sJm06TS/jtxgE72yCocCfwg1nDUTe/dbfCRrvd7jXb+tPOmrFSVlhVVxWFeF7s7H PC6AVpCfdBBEJriv8CeTxw0Q+OTTGAIO9dLI9FI/Ko2/ySYMo+eKWtwaVET1Ox1v tJnhPll5DbOyiH4Gx7lycst4WcyBAJ8W/3+fqjj81aMDa5AkH+DOZ162wIXXHeai pCz504XOCbB7bo/qIt4vPyMrzIHeh5qecx5vqLgxvJS9LEcAcuIC/zeucyZ1KLOi T1D9cJYgioEBF7xaPvrY1xtkv3M62CFwcremBKFDKLHCsbjT1AE= =NP9c -----END PGP SIGNATURE----- --wzbml2k4f4yk4hns--