From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753720AbdCTJd2 (ORCPT ); Mon, 20 Mar 2017 05:33:28 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:59852 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753441AbdCTJcz (ORCPT ); Mon, 20 Mar 2017 05:32:55 -0400 From: Arnd Bergmann To: Mauro Carvalho Chehab Cc: Greg Kroah-Hartman , Alan Cox , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Arnd Bergmann Subject: [PATCH 6/9] staging/atomisp: add PCI dependency Date: Mon, 20 Mar 2017 10:32:22 +0100 Message-Id: <20170320093225.1180723-6-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170320093225.1180723-1-arnd@arndb.de> References: <20170320093225.1180723-1-arnd@arndb.de> X-Provags-ID: V03:K0:JU9OWmLiWZmZA3gBfnYV0m7fouXRvuAII7KUHh1Q725Dh+Z0Q1Z Is+BcySTGIxyLL1bfDObi2lei1jXig28dl9FBooxgt0hJKVqj8P3aohxdKoymEuSHsD9gb2 6cJnbwVLpO6teETIepxdap+AXwgvtbfooEXxqKR8LJssMfmYQSDs5qH7WyHD4LPNPIuOgvi /RtTFvYGCV7E/jI32OW5g== X-UI-Out-Filterresults: notjunk:1;V01:K0:o9I7F7ioxe0=:l3hT8G3urrblE+dIG/qGnV sH4MgaUFX2JMAAwQJC2Ll0KInlRHxqkeRc8ZydMoZHtgU5dRhDwJWNJ+IbohWnbWoO3cgahIw /GAP2YrHhhU3zWfb6MZ5dE5D6aMVZmpOQlK+dcJZv0w5ezDXS/RNnYnZ371hY/JqLU+8CqVhQ RpCDF3Lh1PeEXgV4+y+Beul54SNbDCc9pw/15ELMFyOq98yqpjFTik3C3AJu6lcCHC7OAsw1/ EEqbsIIxp3P1uFtXCzcWkbd4dFp8LAqYJ0g1S9KeJJHK1k2rU5Eiwjvvstm0XT/IgvUXlfkMF tJ67/HZ9mV+S7Yv7o0SJJp1hHR7zRtZ4+Ukvxjdx/lndI/9+WPvET+G9WxPRikwERdMK9s96F J2Q7kOg1dNNjoo6zMNxPEuJD+d0Pc5M3AIDv+4UBen4cpFl4044GrC1mK0RDHXPgXtqYvgync g/A1nMfOWs1XaI5kMyqxeIL9XEaelZ19SdTMYraDbiJjFmeI825R8D4+l0yg7as04qjhr6xP4 ovP6eyo5w8vsJtQiod2TWs/dH/32ygif18ydmDlGavLwhN2Wty4ei1Vigoo6PYNU5oDxuHEoe vAE+6YB2ev3a/9rl53gVx5RmXRDTtjoGSdVkhWHOY2GhJdLebN1fT9SHqZy2Q8+BVN+Rbppcb lDnFGgP5DEp+xli1q2XmgtwYwdYEOhbXFbW3IAlvVv0HdaKoINQh5W/uaOXlfvnB7nqY= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Without CONFIG_PCI, config space reads never return any data, leading to undefined behavior that gcc warns about: platform/intel-mid/intel_mid_pcihelpers.c: In function 'intel_mid_msgbus_read32_raw': platform/intel-mid/intel_mid_pcihelpers.c:66:9: error: 'data' is used uninitialized in this function [-Werror=uninitialized] platform/intel-mid/intel_mid_pcihelpers.c: In function 'intel_mid_msgbus_read32_raw_ext': platform/intel-mid/intel_mid_pcihelpers.c:84:9: error: 'data' is used uninitialized in this function [-Werror=uninitialized] platform/intel-mid/intel_mid_pcihelpers.c: In function 'intel_mid_msgbus_read32': platform/intel-mid/intel_mid_pcihelpers.c:137:9: error: 'data' is used uninitialized in this function [-Werror=uninitialized] With a dependency on CONFIG_PCI, we don't get this warning. This seems safe as PCI config space accessors should always return something when PCI is enabled. Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") Signed-off-by: Arnd Bergmann --- drivers/staging/media/atomisp/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/Kconfig b/drivers/staging/media/atomisp/Kconfig index f7d8a841c629..3af2acdc7e96 100644 --- a/drivers/staging/media/atomisp/Kconfig +++ b/drivers/staging/media/atomisp/Kconfig @@ -1,6 +1,6 @@ menuconfig INTEL_ATOMISP bool "Enable support to Intel MIPI camera drivers" - depends on X86 + depends on X86 && PCI help Enable support for the Intel ISP2 camera interfaces and MIPI sensor drivers. -- 2.9.0