From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753310AbdCTJil (ORCPT ); Mon, 20 Mar 2017 05:38:41 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:53607 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753331AbdCTJhh (ORCPT ); Mon, 20 Mar 2017 05:37:37 -0400 From: Arnd Bergmann To: Lee Jones , Eric Anholt , Stefan Wahren , Greg Kroah-Hartman Cc: Arnd Bergmann , Michael Zoran , Daniel Stone , =?UTF-8?q?Noralf=20Tr=C3=B8nnes?= , popcornmix , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging: vc04_services: make BCM_VIDEOCORE tristate Date: Mon, 20 Mar 2017 10:35:28 +0100 Message-Id: <20170320093544.1213296-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:Zi8sYAWkYb3EhzxBbjBMA/Kchrf/N3LmgqaFWB0mrpUzgpnPCFF njc5a5PzG2NlRDPlR+4FWrHExFFtPtfOd8NnseUPg7m7ZPkvaOZN0CLs4xVOGiboLgcgTpV NbetaghNpfbLcjgIpGws343bl+xJhTCCTY05rpsLvwOzYE12+FcnLBOeGvLBVysFTBu6+bu M0+FB00DDh9gTpyxV6dxw== X-UI-Out-Filterresults: notjunk:1;V01:K0:PSzCzCS/RYo=:JoXG+DnqLrB1elMyIJ/thz qWYyi05aXUwhs1viDVJCiSKL/wRXSgsj9ipvcnOTL1F8QUiDezU4NgFVXiheS6d/UcKv0ph+M dPyM1INWePcIRZ6V17q/5FrNrPccR0QVL0RK/zfcrRXYIxiestauxj/Q1ptjhOdOd/xOw+4py CgGOLTMwoDUitsDnyPLwmxwa/XSyzi7V7ef6HlwZyuVFJ5ippIY84Wpqa78Hu8wlxWuzZuL3J HQDfv1/jxhoqwsg4NcCmBp6LKzLOyEh8gV/XALqzlTlN5g+sSqlbpdXOzcbqBKeoKYwkrSTQB 85xJWFAlBEk+hyNv+oLJFZLMdVXphmETcX8aULyYFn9b/1dnYjC9OElbU4eHhFY+LKvIqZymr r8X60PcpdhyTsv3lbnpHd0l9XzG7P8F4iStdxry1BRZLQcUz902oe6JHw4+FQKl2PQO0+AbpA aiFV5D0tqF/POxqN2IiJKrPnTpL0bHhr27Df2JOgeyuL5GlShDG0OgNUQ7HG9t0ATe+lE6Il2 t5K7hotfv/1RZPMoNCUrs/oFvDmUMqcneCfNOJShUl6FceP1qIysvPxu/J7hAARaZAeVw4+hA d5EQVIXk7it2isdOjqt39yXZeH4laWzsu8ACPeAxEUqID+dwUH4vPs953n1ayTHOtWIZhHQ8v VlhN0/7cw+ILfUlDmlpQ2YX/ABcislndFGrpjAi1JoTa3cILeUcQkymx2cQ7cXScM86Q= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Adding the 'bool' symbol brought back a randconfig build bug that I had fixed before: drivers/staging/built-in.o: In function `vchiq_probe': (.text+0x1da30): undefined reference to `rpi_firmware_get' drivers/staging/built-in.o: In function `vchiq_platform_init': (.text+0x27494): undefined reference to `rpi_firmware_property' The problem is that when RASPBERRYPI_FIRMWARE is a loadable module, but BCM2835_VCHIQ can again be built-in. Making BCM_VIDEOCORE itself tristate will make Kconfig honor the dependency correctly. Fixes: 6bbfe4a76158 ("staging: vc04_services: Create new BCM_VIDEOCORE setting for VideoCore services.") Signed-off-by: Arnd Bergmann --- drivers/staging/vc04_services/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/Kconfig b/drivers/staging/vc04_services/Kconfig index f905df2275cf..9e2763663ab8 100644 --- a/drivers/staging/vc04_services/Kconfig +++ b/drivers/staging/vc04_services/Kconfig @@ -1,5 +1,5 @@ menuconfig BCM_VIDEOCORE - bool "Broadcom VideoCore support" + tristate "Broadcom VideoCore support" depends on HAS_DMA depends on OF depends on RASPBERRYPI_FIRMWARE || (COMPILE_TEST && !RASPBERRYPI_FIRMWARE) -- 2.9.0