From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756075AbdCUC5j (ORCPT ); Mon, 20 Mar 2017 22:57:39 -0400 Received: from LGEAMRELO12.lge.com ([156.147.23.52]:40260 "EHLO lgeamrelo12.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755307AbdCUC5i (ORCPT ); Mon, 20 Mar 2017 22:57:38 -0400 X-Original-SENDERIP: 156.147.1.125 X-Original-MAILFROM: byungchul.park@lge.com X-Original-SENDERIP: 10.177.222.33 X-Original-MAILFROM: byungchul.park@lge.com Date: Tue, 21 Mar 2017 11:56:58 +0900 From: Byungchul Park To: peterz@infradead.org, mingo@kernel.org Cc: peterz@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org, juri.lelli@gmail.com, rostedt@goodmis.org, kernel-team@lge.com, Daniel Bristot de Oliveira Subject: Re: [PATCH v3 1/2] sched/deadline: Remove unnecessary condition in push_dl_task() Message-ID: <20170321025658.GK11100@X58A-UD3R> References: <1487212457-28839-1-git-send-email-byungchul.park@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 16, 2017 at 06:35:54PM +0100, Daniel Bristot de Oliveira wrote: > On 02/16/2017 03:34 AM, Byungchul Park wrote: > > pick_next_pushable_dl_task(rq) has BUG_ON(rq->cpu != task_cpu(task)) > > when it returns a task other than NULL, which means that task_cpu(task) > > must be rq->cpu. So if task == next_task, then task_cpu(next_task) must > > be rq->cpu as well. Remove the redundant condition and make code simpler. > > > > By this patch, unnecessary one branch and two LOAD operations in 'if' > > statement can be avoided. > > > > Signed-off-by: Byungchul Park > > Reviewed-by: Steven Rostedt (VMware) > > Reviewed-by: Juri Lelli > > +1 > > Reviewed-by: Daniel Bristot de Oliveira Hello, Could you check this out? > > -- Daniel