From: "Pranay Kr. Srivastava" <pranjas@gmail.com>
To: w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca,
samuel.thibault@ens-lyon.org, gregkh@linuxfoundation.org,
sfr@canb.auug.org.au, speakup@linux-speakup.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Cc: "Pranay Kr. Srivastava" <pranjas@gmail.com>
Subject: [PATCH staging/speakup v3 2/3] remove unnecessary initial allocation of vc
Date: Tue, 21 Mar 2017 12:40:23 +0530 [thread overview]
Message-ID: <20170321071024.2328-3-pranjas@gmail.com> (raw)
In-Reply-To: <20170321071024.2328-1-pranjas@gmail.com>
This patch removes the unnecessary allocation of
current foreground vc during initialization.
This initialization is already handled in the loop
that follows it for all available virtual consoles.
Signed-off-by: Pranay Kr. Srivastava <pranjas@gmail.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
drivers/staging/speakup/main.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
index a1d5b66..ca817ca 100644
--- a/drivers/staging/speakup/main.c
+++ b/drivers/staging/speakup/main.c
@@ -2317,7 +2317,6 @@ static int __init speakup_init(void)
{
int i;
long err = 0;
- struct st_spk_t *first_console;
struct vc_data *vc = vc_cons[fg_console].d;
struct var_t *var;
@@ -2342,15 +2341,6 @@ static int __init speakup_init(void)
if (err)
goto error_virtkeyboard;
- first_console = kzalloc(sizeof(*first_console), GFP_KERNEL);
- if (!first_console) {
- err = -ENOMEM;
- goto error_alloc;
- }
-
- speakup_console[vc->vc_num] = first_console;
- speakup_date(vc);
-
for (i = 0; i < MAX_NR_CONSOLES; i++)
if (vc_cons[i].d) {
err = speakup_allocate(vc_cons[i].d);
@@ -2412,7 +2402,6 @@ static int __init speakup_init(void)
for (i = 0; i < MAX_NR_CONSOLES; i++)
kfree(speakup_console[i]);
-error_alloc:
speakup_remove_virtual_keyboard();
error_virtkeyboard:
--
2.10.2
next prev parent reply other threads:[~2017-03-21 7:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 8:27 [PATCH SPEAKUP v2 0/3] cleanup error and initilization Pranay Kr. Srivastava
2017-02-28 8:27 ` [PATCH SPEAKUP v2 1/3] return same error value from spk_set_key_info Pranay Kr. Srivastava
2017-02-28 9:04 ` Samuel Thibault
2017-03-01 7:51 ` Greg KH
2017-03-21 7:10 ` [PATCH staging/speakup v3 0/3] cleanup error and initilization Pranay Kr. Srivastava
2017-03-21 7:10 ` [PATCH staging/speakup v3 1/3] return same error value from spk_set_key_info Pranay Kr. Srivastava
2017-03-21 7:10 ` Pranay Kr. Srivastava [this message]
2017-03-21 7:10 ` [PATCH staging/speakup v3 3/3] use speakup_allocate as per required context Pranay Kr. Srivastava
2017-03-23 13:17 ` Greg KH
2017-03-24 8:37 ` [[RESEND]PATCH " Pranay Kr. Srivastava
2017-03-24 8:43 ` Greg KH
2017-03-24 10:14 ` Pranay Srivastava
2017-02-28 8:27 ` [PATCH SPEAKUP v2 2/3] remove unecessary initial allocation of vc Pranay Kr. Srivastava
2017-02-28 9:05 ` Samuel Thibault
2017-02-28 8:27 ` [PATCH SPEAKUP v2 3/3] use spkeaup_allocate as per required context Pranay Kr. Srivastava
2017-02-28 9:05 ` Samuel Thibault
2017-03-01 7:51 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170321071024.2328-3-pranjas@gmail.com \
--to=pranjas@gmail.com \
--cc=chris@the-brannons.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=sfr@canb.auug.org.au \
--cc=speakup@linux-speakup.org \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome