From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932480AbdCUNvl (ORCPT ); Tue, 21 Mar 2017 09:51:41 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:44994 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757235AbdCUNvj (ORCPT ); Tue, 21 Mar 2017 09:51:39 -0400 From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Arnd Bergmann , Javier Martinez Canillas , Greg Kroah-Hartman Subject: [PATCH v2 1/3] misc: tsl2550: Add OF device ID table Date: Tue, 21 Mar 2017 10:50:47 -0300 Message-Id: <20170321135049.16211-1-javier@osg.samsung.com> X-Mailer: git-send-email 2.9.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver doesn't have a struct of_device_id table but supported devices are registered via Device Trees. This is working on the assumption that a I2C device registered via OF will always match a legacy I2C device ID and that the MODALIAS reported will always be of the form i2c:. But this could change in the future so the correct approach is to have an OF device ID table if the devices are registered via OF. Signed-off-by: Javier Martinez Canillas --- Changes in v2: - Avoid using of_match_ptr() macro which leads to build warnings when CONFIG_OF is not enabled (Arnd Bergmann). drivers/misc/tsl2550.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/misc/tsl2550.c b/drivers/misc/tsl2550.c index 87a13374fdc0..adf46072cb37 100644 --- a/drivers/misc/tsl2550.c +++ b/drivers/misc/tsl2550.c @@ -443,9 +443,16 @@ static const struct i2c_device_id tsl2550_id[] = { }; MODULE_DEVICE_TABLE(i2c, tsl2550_id); +static const struct of_device_id tsl2550_of_match[] = { + { .compatible = "taos,tsl2550" }, + { } +}; +MODULE_DEVICE_TABLE(of, tsl2550_of_match); + static struct i2c_driver tsl2550_driver = { .driver = { .name = TSL2550_DRV_NAME, + .of_match_table = tsl2550_of_match, .pm = TSL2550_PM_OPS, }, .probe = tsl2550_probe, -- 2.9.3