From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932622AbdCUNvo (ORCPT ); Tue, 21 Mar 2017 09:51:44 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:45001 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757258AbdCUNvj (ORCPT ); Tue, 21 Mar 2017 09:51:39 -0400 From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Arnd Bergmann , Javier Martinez Canillas , Greg Kroah-Hartman Subject: [PATCH v2 2/3] misc: ds1682: Add OF device ID table Date: Tue, 21 Mar 2017 10:50:48 -0300 Message-Id: <20170321135049.16211-2-javier@osg.samsung.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170321135049.16211-1-javier@osg.samsung.com> References: <20170321135049.16211-1-javier@osg.samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver doesn't have a struct of_device_id table but supported devices are registered via Device Trees. This is working on the assumption that a I2C device registered via OF will always match a legacy I2C device ID and that the MODALIAS reported will always be of the form i2c:. But this could change in the future so the correct approach is to have an OF device ID table if the devices are registered via OF. Signed-off-by: Javier Martinez Canillas --- Changes in v2: - Avoid using of_match_ptr() macro which leads to build warnings when CONFIG_OF is not enabled (Arnd Bergmann). drivers/misc/ds1682.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/misc/ds1682.c b/drivers/misc/ds1682.c index c7112276a039..28bb495f0cf1 100644 --- a/drivers/misc/ds1682.c +++ b/drivers/misc/ds1682.c @@ -227,9 +227,16 @@ static const struct i2c_device_id ds1682_id[] = { }; MODULE_DEVICE_TABLE(i2c, ds1682_id); +static const struct of_device_id ds1682_of_match[] = { + { .compatible = "dallas,ds1682", }, + {} +}; +MODULE_DEVICE_TABLE(of, ds1682_of_match); + static struct i2c_driver ds1682_driver = { .driver = { .name = "ds1682", + .of_match_table = ds1682_of_match, }, .probe = ds1682_probe, .remove = ds1682_remove, -- 2.9.3