From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932791AbdCUOSC (ORCPT ); Tue, 21 Mar 2017 10:18:02 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:35873 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756870AbdCUOSA (ORCPT ); Tue, 21 Mar 2017 10:18:00 -0400 Date: Tue, 21 Mar 2017 07:17:58 -0700 From: Matthew Giassa To: Dan Carpenter Cc: forest@alittletooquiet.net, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] staging: vt6656: rf.c: spaces preferred around that '-' Message-ID: <20170321141758.2tkatnqyphdpw7rm@darkstar> References: <1490067961-6661-1-git-send-email-matthew@giassa.net> <1490067961-6661-3-git-send-email-matthew@giassa.net> <20170321125551.GC32449@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20170321125551.GC32449@mwanda> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Dan Carpenter [2017-03-21 15:55:52 +0300]: >On Mon, Mar 20, 2017 at 08:46:01PM -0700, Matthew Giassa wrote: >> Resolving 2 checkpatch warnings generated due to: >> CHECK: spaces preferred around that '-' >> >> Signed-off-by: Matthew Giassa >> --- >> drivers/staging/vt6656/rf.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c >> index 0e3a62a..fe09627 100644 >> --- a/drivers/staging/vt6656/rf.c >> +++ b/drivers/staging/vt6656/rf.c >> @@ -611,7 +611,7 @@ int vnt_rf_write_embedded(struct vnt_private *priv, u32 data) >> reg_data[3] = (u8)(data >> 24); >> >> vnt_control_out(priv, MESSAGE_TYPE_WRITE_IFRF, >> - 0, 0, ARRAY_SIZE(reg_data), reg_data); >> + 0, 0, ARRAY_SIZE(reg_data), reg_data); > >This isn't described in the changelog. > >regards, >dan carpenter > Would it be preferable if the changelog was more verbose? The literal text from the checkpatch.pl warning itself is indeed in the changelog: >On Mon, Mar 20, 2017 at 08:46:01PM -0700, Matthew Giassa wrote: >> Resolving 2 checkpatch warnings generated due to: >> CHECK: spaces preferred around that '-' Cheers.