From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965279AbdCVRyL (ORCPT ); Wed, 22 Mar 2017 13:54:11 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:42192 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935398AbdCVRxQ (ORCPT ); Wed, 22 Mar 2017 13:53:16 -0400 Date: Wed, 22 Mar 2017 10:53:14 -0700 (PDT) Message-Id: <20170322.105314.1598893528436587108.davem@davemloft.net> To: arnd@arndb.de Cc: jiedeng@synopsys.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] [net-next] net: dwc-xlgmac: add module license From: David Miller In-Reply-To: <20170320085123.1032301-2-arnd@arndb.de> References: <20170320085123.1032301-1-arnd@arndb.de> <20170320085123.1032301-2-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 22 Mar 2017 10:53:15 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Mon, 20 Mar 2017 09:51:13 +0100 > When building the driver as a module, we get a warning about the > lack of a license: > > WARNING: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/synopsys/dwc-xlgmac.o > see include/linux/module.h for more information > > Curiously the text in the .c files only mentions GPLv2+, while the license > tag in the PCI driver contains both GPL and BSD. I picked the license text > as the more definite reference here and put a GPL tag in there. > > Fixes: 65e0ace2c5cd ("net: dwc-xlgmac: Initial driver for DesignWare Enterprise Ethernet") > Signed-off-by: Arnd Bergmann Applied.