From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965377AbdCVR5H (ORCPT ); Wed, 22 Mar 2017 13:57:07 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:42228 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965180AbdCVR5E (ORCPT ); Wed, 22 Mar 2017 13:57:04 -0400 Date: Wed, 22 Mar 2017 10:57:03 -0700 (PDT) Message-Id: <20170322.105703.567983727621129027.davem@davemloft.net> To: arnd@arndb.de Cc: grygorii.strashko@ti.com, tglx@linutronix.de, richardcochran@gmail.com, u.kleine-koenig@pengutronix.de, nicolas.pitre@linaro.org, w-kwok2@ti.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [v2, -net] cpsw/netcp: work around reverse cpts dependency From: David Miller In-Reply-To: <20170320085339.1033988-1-arnd@arndb.de> References: <20170320085339.1033988-1-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 22 Mar 2017 10:57:03 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Mon, 20 Mar 2017 09:52:50 +0100 > The dependency is reversed: cpsw and netcp call into cpts, > but cpts depends on the other two in Kconfig. This can lead > to cpts being a loadable module and its callers built-in: > > drivers/net/ethernet/ti/cpsw.o: In function `cpsw_remove': > cpsw.c:(.text.cpsw_remove+0xd0): undefined reference to `cpts_release' > drivers/net/ethernet/ti/cpsw.o: In function `cpsw_rx_handler': > cpsw.c:(.text.cpsw_rx_handler+0x2dc): undefined reference to `cpts_rx_timestamp' > drivers/net/ethernet/ti/cpsw.o: In function `cpsw_tx_handler': > cpsw.c:(.text.cpsw_tx_handler+0x7c): undefined reference to `cpts_tx_timestamp' > drivers/net/ethernet/ti/cpsw.o: In function `cpsw_ndo_stop': > > As a workaround, I'm introducing another Kconfig symbol to > control the compilation of cpts, while making the actual > module controlled by a silent symbol that is =y when necessary. > > Fixes: 6246168b4a38 ("net: ethernet: ti: netcp: add support of cpts") > Signed-off-by: Arnd Bergmann > Reviewed-by: Grygorii Strashko > --- > v1: Originally submitted on Dec 16, still needed for v4.10 and v4.11-rc2 > v2: change the symbol names to keep existing defconfigs working I've applied these two cpsw fixes, thanks Arnd.