From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934022AbdCVKWo (ORCPT ); Wed, 22 Mar 2017 06:22:44 -0400 Received: from mail-pf0-f182.google.com ([209.85.192.182]:36479 "EHLO mail-pf0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933720AbdCVKWg (ORCPT ); Wed, 22 Mar 2017 06:22:36 -0400 Date: Wed, 22 Mar 2017 15:26:15 +0530 From: Viresh Kumar To: Peter Zijlstra Cc: "Rafael J. Wysocki" , Linux PM , LKML , Patrick Bellasi , Vincent Guittot Subject: Re: [PATCH] cpufreq: schedutil: Always trace frequency if it does not change Message-ID: <20170322095615.GB12094@vireshk-i7> References: <10655562.4O9KtquB0A@aspire.rjw.lan> <20170322092951.GX5680@worktop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170322092951.GX5680@worktop> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22-03-17, 10:29, Peter Zijlstra wrote: > On Wed, Mar 22, 2017 at 01:56:53AM +0100, Rafael J. Wysocki wrote: > > However, the same problem may occur for a cpufreq driver that doesn't > > support fast frequency switching and implements the ->target callback > > (that is, it doesn't use frequency tables), but trace_cpu_frequency() > > is not called if frequency updates are skipped in that case. > > I'm having trouble parsing that; am I right in understanding this is the > exact same scenario where only superfluous changes are omitted? Yes. Just for a different driver type. -- viresh