From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934318AbdCVLa0 (ORCPT ); Wed, 22 Mar 2017 07:30:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40288 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759250AbdCVL3i (ORCPT ); Wed, 22 Mar 2017 07:29:38 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8F3AD61D01 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=hdegoede@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 8F3AD61D01 From: Hans de Goede To: "Rafael J . Wysocki" , Len Brown , Lee Jones Cc: Hans de Goede , Andy Shevchenko , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/5] ACPI / PMIC: mfd: intel_pmic_chtwc: This driver must always be builtin Date: Wed, 22 Mar 2017 12:29:23 +0100 Message-Id: <20170322112923.20200-6-hdegoede@redhat.com> In-Reply-To: <20170322112923.20200-1-hdegoede@redhat.com> References: <20170322112923.20200-1-hdegoede@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 22 Mar 2017 11:29:37 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The chtwc PMIC provides an ACPI OPRegion handler, which must be available before other drivers using it are loaded, which can only be ensured if both the mfd and opregion drivers are built in. This fixes errors like these during boot: mmc0: SDHCI controller on ACPI [80860F14:00] using ADMA ACPI Error: No handler for Region [REGS] (ffff93543b0cc3a8) [UserDefinedRegion] (20170119/evregion-166) ACPI Error: Region UserDefinedRegion (ID=143) has no handler (20170119/exfldio-299) ACPI Error: Method parse/execution failed [\_SB.PCI0.I2C7.PMI5.GET] (Node ffff93543b0cde10), AE_NOT_EXIST (20170119/psparse-543) ACPI Error: Method parse/execution failed [\_SB.PCI0.SHC1._PS0] (Node ffff93543b0b5cd0), AE_NOT_EXIST (20170119/psparse-543) acpi 80860F14:02: Failed to change power state to D0 Signed-off-by: Hans de Goede --- drivers/acpi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig index ec09fa2..842530f 100644 --- a/drivers/acpi/Kconfig +++ b/drivers/acpi/Kconfig @@ -517,7 +517,7 @@ config BXT_WC_PMIC_OPREGION This config adds ACPI operation region support for BXT WhiskeyCove PMIC. config CHT_WC_PMIC_OPREGION - tristate "ACPI operation region support for CHT Whiskey Cove PMIC" + bool "ACPI operation region support for CHT Whiskey Cove PMIC" depends on INTEL_SOC_PMIC_CHTWC help This config adds ACPI operation region support for CHT Whiskey Cove PMIC. -- 2.9.3